Pin mongomock (IDSIA#934)

* Enable pymongo tests for Python 3.10+ since mongomock now supports newer python versions * Pin pymongo to a version before 4.9
nagyist · Oct 17, 2024 · 8562dc8 · 8562dc8
1 parent d728e32
commit 8562dc8
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/dev-requirements.txt b/dev-requirements.txt
@@ -24,7 +24,7 @@ tinydb
 tinydb-serialization
 wrapt
 scikit-learn
-pymongo
+pymongo<4.9 # mongomock.gridfs.enable_gridfs_integration() is not compatible with pymongo>=4.9. https://github.com/mongomock/mongomock/issues/903
 py-cpuinfo
 boto3
 moto

diff --git a/tests/test_observers/test_queue_mongo_observer.py b/tests/test_observers/test_queue_mongo_observer.py
@@ -1,15 +1,6 @@
 import datetime
-from sacred.observers.queue import QueueObserver
 import mock
 import pytest
-import sys
-
-if sys.version_info >= (3, 10):
-    pytest.skip(
-        "Skip pymongo tests for Python 3.10 because mongomock doesn't "
-        "support Python 3.10",
-        allow_module_level=True,
-    )
 
 from sacred.metrics_logger import ScalarMetricLogEntry, linearize_metrics
 
@@ -25,7 +16,6 @@
 from sacred.observers.mongo import (
     QueuedMongoObserver,
     MongoObserver,
-    QueueCompatibleMongoObserver,
 )
 from .failing_mongo_mock import ReconnectingMongoClient