Improve go linting scripts (improbable-eng#340)

* Fix gofmt issue

* Improve linting script

* Tighten up what gets printed.

* Print output generated by `generate-docs.sh` on failure.

* Fix invocation of lint script by Travis

go/generate-docs.sh

@@ -0,0 +1,12 @@
+#!/bin/bash
+
+echo "Generating markdown using godocdown in..."
+oldpwd="$(pwd)"
+for i in $(find . -iname 'doc.go'); do
+    dir="${i%/*}"
+    echo "- $dir"
+    cd "${dir}"
+    "${GOPATH}/bin/godocdown" -heading=Title -o DOC.md
+    ln -s DOC.md README.md 2> /dev/null # can fail
+    cd "${oldpwd}"
+done;

go/grpcwebproxy/main.go

@@ -30,7 +30,7 @@ var (
 	flagBindAddr    = pflag.String("server_bind_address", "0.0.0.0", "address to bind the server to")
 	flagHttpPort    = pflag.Int("server_http_debug_port", 8080, "TCP port to listen on for HTTP1.1 debug calls.")
 	flagHttpTlsPort = pflag.Int("server_http_tls_port", 8443, "TCP port to listen on for HTTPS (gRPC, gRPC-Web).")
-	
+
 	runHttpServer = pflag.Bool("run_http_server", true, "whether to run HTTP server")
 	runTlsServer  = pflag.Bool("run_tls_server", true, "whether to run TLS server")
 

go/lint.sh

@@ -0,0 +1,62 @@
+#!/bin/bash
+# Script that checks the code for errors.
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd -P)"
+
+function print_real_go_files {
+    grep --files-without-match 'DO NOT EDIT!' $(find . -iname '*.go')
+}
+
+function check_no_documentation_changes {
+  echo "- Running generate-docs.sh"
+  output=$(./generate-docs.sh)
+  if [[ $? -ne 0 ]]; then
+    echo $output
+    echo "ERROR: Failed to generate documentation."
+    exit 1
+  fi
+
+  git diff --name-only | grep -q DOC.md
+  if [[ $? -ne 1 ]]; then
+    echo "ERROR: Documentation changes detected, please commit them."
+    exit 1
+  fi
+}
+
+function check_gofmt {
+    echo "- Running gofmt"
+    out=$(gofmt -l -w $(print_real_go_files))
+    if [[ ! -z $out ]]; then
+        echo "ERROR: gofmt changes detected, please commit them."
+        exit 1
+    fi
+}
+
+function goimports_all {
+    echo "- Running goimports"
+    ${GOPATH}/bin/goimports -l -w $(print_real_go_files)
+    if [[ $? -ne 0 ]]; then
+        echo "ERROR: goimports changes detected, please commit them."
+        exit 1
+    fi
+}
+
+function govet_all {
+    echo "- Running govet"
+    ret=0
+    for i in $(print_real_go_files); do
+        output=$(go tool vet -all=true -tests=false ${i})
+        ret=$(($ret | $?))
+        echo -n ${output}
+    done;
+    if [[ $ret -ne 0 ]]; then
+        echo "ERROR: govet errors detected, please commit/fix them."
+        exit 1
+    fi
+}
+
+check_no_documentation_changes
+check_gofmt
+goimports_all
+govet_all
+echo

lint-all.sh

@@ -3,10 +3,7 @@
 set -e
 
 echo "Linting go sources"
-pushd ./go
-./checkup.sh
-./fixup.sh
-popd
+cd go && ./lint.sh && cd ..
 
-echo "Linting Typescript sources"
+echo "Linting TypeScript sources"
 npm run lint