lint: constants for http status codes

mw_ip_whitelist.go

@@ -36,13 +36,13 @@ func (i *IPWhiteListMiddleware) ProcessRequest(w http.ResponseWriter, r *http.Re
 		// Check CIDR if possible
 		if allowedNet != nil && allowedNet.Contains(remoteIP) {
 			// matched, pass through
-			return nil, 200
+			return nil, http.StatusOK
 		}
 
 		// We parse the IP to manage IPv4 and IPv6 easily
 		if allowedIP.Equal(remoteIP) {
 			// matched, pass through
-			return nil, 200
+			return nil, http.StatusOK
 		}
 	}
 
@@ -52,5 +52,5 @@ func (i *IPWhiteListMiddleware) ProcessRequest(w http.ResponseWriter, r *http.Re
 	reportHealthValue(i.Spec, KeyFailure, "-1")
 
 	// Not matched, fail
-	return errors.New("Access from this IP has been disallowed"), 403
+	return errors.New("access from this IP has been disallowed"), http.StatusForbidden
 }

mw_ip_whitelist_test.go

@@ -1,6 +1,7 @@
 package main
 
 import (
+	"net/http"
 	"net/http/httptest"
 	"testing"
 )
@@ -15,11 +16,11 @@ func TestIPMiddlewarePass(t *testing.T) {
 		remote, forwarded string
 		wantCode          int
 	}{
-		{"127.0.0.1:80", "", 200},         // remote exact match
-		{"127.0.0.2:80", "", 200},         // remote CIDR match
-		{"10.0.0.1:80", "", 403},          // no match
-		{"10.0.0.1:80", "127.0.0.1", 200}, // forwarded exact match
-		{"10.0.0.1:80", "127.0.0.2", 200}, // forwarded CIDR match
+		{"127.0.0.1:80", "", http.StatusOK},         // remote exact match
+		{"127.0.0.2:80", "", http.StatusOK},         // remote CIDR match
+		{"10.0.0.1:80", "", http.StatusForbidden},   // no match
+		{"10.0.0.1:80", "127.0.0.1", http.StatusOK}, // forwarded exact match
+		{"10.0.0.1:80", "127.0.0.2", http.StatusOK}, // forwarded CIDR match
 	} {
 		rec := httptest.NewRecorder()
 		req := testReq(t, "GET", "/", nil)