Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMT-3314: Updating UMM-C to 1.18.3 #1341

Merged
merged 3 commits into from
Mar 19, 2025
Merged

MMT-3314: Updating UMM-C to 1.18.3 #1341

merged 3 commits into from
Mar 19, 2025

Conversation

mandyparson
Copy link
Contributor

@mandyparson mandyparson commented Mar 17, 2025

Overview

What is the feature?

Update UMM-C schema from 1.18.2 to 1.18.3 as seen here: https://git.earthdata.nasa.gov/projects/EMFD/repos/unified-metadata-model/browse/collection/v1.18.3

Also ran an npm audit fix. Went from this: 16 vulnerabilities (1 low, 11 moderate, 3 high, 1 critical) to this: 15 vulnerabilities (1 low, 11 moderate, 3 high). The critical fix was:
xml-crypto 3.0.0 - 3.2.0
Severity: critical
xml-crypto Vulnerable to XML Signature Verification Bypass via DigestValue Comment - GHSA-x3m8-899r-f7c3
xml-crypto Vulnerable to XML Signature Verification Bypass via Multiple SignedInfo References - GHSA-9p8x-f768-wp2g
fix available via npm audit fix

What is the Solution?

Changes include:
UMM-C schema added URLMimeType enum "application/geo+json"
UMM-C schema updated 'DOI/PreviousVersion/Version' definition
UMM-C schema corrected spelling for Temporal resolution 'Constant'
UMM-C schema updated media type definition

What areas of the application does this impact?

UmmCSchema

Testing

Reproduction steps

  • **Environment for testing: local
  • Collection to test with:
  1. Run GQL-103 with MMT-3314 and make sure you can see changes above reflected in form.
  2. Step 2...

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (f365fd9) to head (a62e632).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1341   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files         365      365           
  Lines        5763     5763           
  Branches     1213     1213           
=======================================
  Hits         5630     5630           
  Misses        132      132           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eereiter
Copy link

When running MMT, I saw under RelatedUrls > URLContentType=DistributionURL > Type=Use Service API > Get Service > MimeType has a value of application/geo_json. Where does this value come from? Why is the underscore used instead of the plus (+) symbol? I think the value should be application/geo+json

@mandyparson mandyparson requested a review from dmistry1 March 19, 2025 14:30
@mandyparson
Copy link
Contributor Author

When running MMT, I saw under RelatedUrls > URLContentType=DistributionURL > Type=Use Service API > Get Service > MimeType has a value of application/geo_json. Where does this value come from? Why is the underscore used instead of the plus (+) symbol? I think the value should be application/geo+json

See github bug here: https://bugs.earthdata.nasa.gov/browse/MMT-3976

@mandyparson mandyparson merged commit 97d5f3c into main Mar 19, 2025
15 of 17 checks passed
@mandyparson mandyparson deleted the MMT-3314 branch March 19, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants