Skip to content

MMT-4010: As a user, I can navigate to a landing page for Keyword Manager. #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2025

Conversation

mandyparson
Copy link
Contributor

@mandyparson mandyparson commented Apr 14, 2025

Overview

What is the feature?

Authorized users can access the Keyword Manager underneath the Admin header.

What is the Solution?

Under Admin, there is now a tab for Keyword Manager. This tab is only visible to users with access to the Keyword Manager. At the moment, the permission endpoint for this is awaiting creating with CMR-10495. For now, we are using the Group permission to test this.

What areas of the application does this impact?

Navigations and new Keyword Manager landing page

Testing

Reproduction steps

  • **Environment for testing: SIT
  • **Collection to test with: N/A
  1. Point local environment to SIT and log on.
  2. Under usePermissions.js, change line 30 to 'GROUP'. (change back to KEYWORDS before running tests)
  3. Load page and see that Keyword Manager is accessible under Admin.

Attachments

Screenshot 2025-04-14 at 2 49 38 PM

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.68%. Comparing base (069d709) to head (a9e75bf).

Files with missing lines Patch % Lines
...js/pages/KeywordManagerPage/KeywordManagerPage.jsx 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1349      +/-   ##
==========================================
- Coverage   97.69%   97.68%   -0.02%     
==========================================
  Files         365      366       +1     
  Lines        5763     5780      +17     
  Branches     1215     1207       -8     
==========================================
+ Hits         5630     5646      +16     
- Misses        132      133       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mandyparson mandyparson merged commit 46fce2e into main Apr 16, 2025
19 of 22 checks passed
@mandyparson mandyparson deleted the MMT-4010 branch April 16, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants