Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework server rendering approach #10

Merged
merged 12 commits into from
Oct 25, 2023
Merged

Rework server rendering approach #10

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
32992af
Use native node for server rendering & cleanup contents templates
natewong1313 Oct 24, 2023
27fc3b5
Use strings.builder for server render node calls
natewong1313 Oct 24, 2023
1b768be
Remove unused config
natewong1313 Oct 24, 2023
4e9693f
Add material ui example
natewong1313 Oct 24, 2023
b8b076d
Update docker files
natewong1313 Oct 24, 2023
4e07cf6
Tidy go mod
natewong1313 Oct 24, 2023
add26d7
Update cli to add styling plugin options
natewong1313 Oct 24, 2023
4178991
Fix server build not getting cached
natewong1313 Oct 24, 2023
7deb425
Concise return statement
natewong1313 Oct 24, 2023
8b31d4f
Simplify rendering
natewong1313 Oct 25, 2023
219371b
Fix Gin test not installing node deps
natewong1313 Oct 25, 2023
cf3c760
Fix example tests
natewong1313 Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use strings.builder for server render node calls
  • Loading branch information
@natewong1313
natewong1313 committed Oct 24, 2023
commit 27fc3b590ee7a5d57177ab15a278ff56d0629d59
12 changes: 9 additions & 3 deletions internal/reactbuilder/render.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,20 @@
package reactbuilder

import (
"errors"
"os/exec"
"strings"
)

func RenderReactToHTML(serverRenderJSFilePath string) (string, error) {
cmd := exec.Command("node", serverRenderJSFilePath)
out, err := cmd.CombinedOutput()
stdOut := new(strings.Builder)
stdErr := new(strings.Builder)
cmd.Stdout = stdOut
cmd.Stderr = stdErr
err := cmd.Run()
if err != nil {
return "", err
return "", errors.New(stdErr.String())
}
return string(out), nil
return stdOut.String(), nil
}