[FIXED] Avoid ack id collision in PublishAsync #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrpio
force-pushed
the
publish-async-deadlock
branch
from
a9252ba to
19aa068
Compare
wallyqs
reviewed
Mar 3, 2025
js.go
Outdated
| l /= base | ||
| } | ||
| replyID := string(b[:]) | ||
| if _, ok := js.pafs[replyID]; ok { |
There was a problem hiding this comment.
I think it would be better to avoid keeping the string and let do Write use the bytes as it was before
Suggested change
| if _, ok := js.pafs[replyID]; ok { | |
| if _, ok := js.pafs[string(b[:])]; ok { |
Signed-off-by: Piotr Piotrowski <[email protected]>
piotrpio
force-pushed
the
publish-async-deadlock
branch
from
19aa068 to
ac4b278
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1801
Signed-off-by: Piotr Piotrowski [email protected]