Skip to content

Commit

Permalink
Fix incorrect comparison in RowSignature. (apache#11905)
Browse files Browse the repository at this point in the history
PR apache#11882 introduced a type comparison using ==, but while it was in flight,
another PR apache#11713 changed the type enum to a class. So the comparison should
properly be done with "equals".
  • Loading branch information
gianm authored Nov 11, 2021
1 parent 57ed512 commit fe2f774
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ public Builder addAggregators(final List<AggregatorFactory> aggregators, final F
default:
assert finalization == Finalization.UNKNOWN;

if (aggregator.getType() == aggregator.getFinalizedType()) {
if (aggregator.getType().equals(aggregator.getFinalizedType())) {
type = aggregator.getType();
} else {
// Use null if the type depends on whether the aggregator is finalized, since we don't know if
Expand Down

0 comments on commit fe2f774

Please sign in to comment.