Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed generation of performance test endpoints for Nautobot apps. #6964

Merged
merged 6 commits into from
Feb 28, 2025

Conversation

HanlinMiao
Copy link
Contributor

Closes #6858

What's Changed

Instead of taking an "educated guess" of the nautobot app base_url, I refactored the command to take the base_url directly from the installed apps' respective AppConfig.

We do have unit tests in place to test all the generated endpoints, I included some of the apps seen on demo.nautobot.com to show the mechanism is working correctly.
I will remove them from pyproject.toml and poetry.lock if the PR is approved

Screenshots

N/A

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Example App Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@HanlinMiao HanlinMiao merged commit c78693b into develop Feb 28, 2025
17 checks passed
@HanlinMiao HanlinMiao deleted the u/hanlin-#6858 branch February 28, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate correct performance test endpoints for Nautobot apps installed
2 participants