[WIP] CI #12
Closed
[WIP] CI #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doshitan
force-pushed
the
doshitan/ci
branch
29 times, most recently
from
da69eb6 to
7388e45
Compare
doshitan
force-pushed
the
doshitan/ci
branch
from
34c75c7 to
8608e71
Compare
Catch it up on some breaking changes and generally try to make it less brittle. Mount a host log directory for the tool inside docker to write to. Mount the host gitconfig (if it exists), so git commits work inside docker. Try to mount any argument that looks like a host path into the docker environment, with the same path. Dropping the special handling for the "project dir" location. Remove the setuid bits from `bin/docker-entry`. Using docker-wrapper is pretty much required, so avoid extra work.
They don't actually assert things are correct, just that the commands run without error, which for a start is useful. Could, and maybe should, be a pytest test suite long-term, but at least for now wanted something that just needed the tool installed to run.
Test building/installing/running tooling via a few different means, on both Linux and macOS (where straightforward to support).
The template should have some content and a commit. Testing against an bare template doesn't really make sense.
This is mainly for testing scenarios, where we may clone a repository to a tmp directory that doesn't use the template name. But good to expose something to end users directly for this as well, since we follow a variety of conventions based on the template name.
Clearer/more consistent messaging to the user than Copier's error.
`git commit` will exit with code `1` if there's nothing to commit, so check first for clearer messaging to the end user and simplified "error"/non-zero exit code handling.
For "updating" a template with new answers, but keeping the same version.
|
Merged and pushed locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10