Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADR for notifications #830

Merged
merged 8 commits into from
Feb 13, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make small edits
  • Loading branch information
lorenyu committed Jan 14, 2025
commit 6db8b23baa04e449fdd707c141914f86334ca3d8
6 changes: 3 additions & 3 deletions docs/decisions/infra/2025-01-09-notifications-architecture.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ The goal is to design a notifications infrastructure that simplifies setup for p
## Decision Drivers

- Avoid circular dependencies.
- Avoid revisiting a layer (e.g., database layer, application layer) more than once during application environment setup.
- Avoid revisiting a layer (e.g., network layer, service layer) more than once during application environment setup.
- Keep the architecture simple to understand and customize.
- Minimize the number of steps required to set up an environment.
- Ensure the solution is testable at each step.
Expand Down Expand Up @@ -80,6 +80,6 @@ The goal is to design a notifications infrastructure that simplifies setup for p

**Summary of chosen options**:

- Use the domain of the environment (e.g., hosted zone) for the sender's email address.
- Create resources in the service layer of one app and require custom work for others to access the notifications service in the app that contains that service.
- Use the domain of the environment (e.g. hosted zone) for the sender's email address.
- Create resources in the service layer of one app and require custom work for other applications in the same repo to access the notifications service.
- Create DKIM and DMARC DNS Records in the service layer.