Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hackathon: dask backend #111

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Hackathon: dask backend #111

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
14555c7
tests: explicitly test equality to serial results
aschampion Oct 6, 2022
8a953b0
tests: add trivial benchmark of parallel perf
aschampion Oct 6, 2022
41e5b60
map_neuronlist: always respect explicit inplace kwarg
aschampion Oct 7, 2022
1a7d734
WIP factor executors, add dask
aschampion Oct 7, 2022
cbc7a06
combine_neurons: fix bug in error message
aschampion Oct 11, 2022
166440c
neuron: fix type annotations for neuron subclasses
aschampion Oct 11, 2022
90b08c0
io: fix literal type annotations
aschampion Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
combine_neurons: fix bug in error message
  • Loading branch information
@aschampion
aschampion committed Oct 11, 2022
commit cbc7a061b788092ca0028c35343e1dfe5c2235c8
2 changes: 1 addition & 1 deletion navis/morpho/manipulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -937,7 +937,7 @@ def combine_neurons(*x: Union[Sequence[NeuronObject], 'core.NeuronList']
elif isinstance(nl[0], core.VoxelNeuron):
raise TypeError('Combining VoxelNeuron not (yet) supported')
else:
raise TypeError(f'Unable to combine {ty}')
raise TypeError(f'Unable to combine {type(nl[0])}')

return x

Expand Down