Skip to content

Commit

Permalink
update tests
Browse files Browse the repository at this point in the history
  • Loading branch information
luacmartins committed Mar 29, 2023
1 parent ea9d4b9 commit 4a8bce9
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion tests/unit/GithubUtilsTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ describe('GithubUtils', () => {
internalQAPRList: [],
isTimingDashboardChecked: false,
isFirebaseChecked: false,
isGHStatusChecked: false,
};
const expectedResponseWithDeployBlockers = {...baseExpectedResponse};
expectedResponseWithDeployBlockers.deployBlockers = [
Expand Down Expand Up @@ -404,6 +405,8 @@ describe('GithubUtils', () => {
const timingDashboardVerification = 'I checked the [App Timing Dashboard](https://graphs.expensify.com/grafana/d/yj2EobAGz/app-timing?orgId=1) and verified this release does not cause a noticeable performance regression.';
// eslint-disable-next-line max-len
const firebaseVerification = 'I checked [Firebase Crashlytics](https://console.firebase.google.com/u/0/project/expensify-chat/crashlytics/app/android:com.expensify.chat/issues?state=open&time=last-seven-days&tag=all) and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found [here](https://stackoverflowteams.com/c/expensify/questions/15095/15096).';
// eslint-disable-next-line max-len
const ghVerification = 'I checked [GitHub Status](https://www.githubstatus.com/) and verified there is no reported incident with Actions.';

// Valid output which will be reused in the deploy blocker tests
const allVerifiedExpectedOutput = `${baseExpectedOutput}`
Expand All @@ -427,6 +430,7 @@ describe('GithubUtils', () => {
+ `${lineBreakDouble}${deployerVerificationsHeader}`
+ `${lineBreak}${openCheckbox}${timingDashboardVerification}`
+ `${lineBreak}${openCheckbox}${firebaseVerification}`
+ `${lineBreak}${openCheckbox}${ghVerification}`
+ `${lineBreakDouble}${ccApplauseLeads}`,
);
})
Expand All @@ -445,6 +449,7 @@ describe('GithubUtils', () => {
+ `${lineBreakDouble}${deployerVerificationsHeader}`
+ `${lineBreak}${openCheckbox}${timingDashboardVerification}`
+ `${lineBreak}${openCheckbox}${firebaseVerification}`
+ `${lineBreak}${openCheckbox}${ghVerification}`
+ `${lineBreakDouble}${ccApplauseLeads}`,
);
})
Expand All @@ -458,6 +463,7 @@ describe('GithubUtils', () => {
+ `${lineBreak}${deployerVerificationsHeader}`
+ `${lineBreak}${openCheckbox}${timingDashboardVerification}`
+ `${lineBreak}${openCheckbox}${firebaseVerification}`
+ `${lineBreak}${openCheckbox}${ghVerification}`
+ `${lineBreakDouble}${ccApplauseLeads}`,
);
})
Expand All @@ -473,7 +479,8 @@ describe('GithubUtils', () => {
+ `${lineBreak}${openCheckbox}${baseDeployBlockerList[1]}`
+ `${lineBreakDouble}${deployerVerificationsHeader}`
+ `${lineBreak}${openCheckbox}${timingDashboardVerification}`
+ `${lineBreak}${openCheckbox}${firebaseVerification}${lineBreak}`
+ `${lineBreak}${openCheckbox}${firebaseVerification}`
+ `${lineBreak}${openCheckbox}${ghVerification}${lineBreak}`
+ `${lineBreak}${ccApplauseLeads}`,
);
})
Expand All @@ -490,6 +497,7 @@ describe('GithubUtils', () => {
+ `${lineBreakDouble}${deployerVerificationsHeader}`
+ `${lineBreak}${openCheckbox}${timingDashboardVerification}`
+ `${lineBreak}${openCheckbox}${firebaseVerification}`
+ `${lineBreak}${openCheckbox}${ghVerification}`
+ `${lineBreakDouble}${ccApplauseLeads}`,
);
})
Expand All @@ -511,6 +519,7 @@ describe('GithubUtils', () => {
+ `${lineBreakDouble}${deployerVerificationsHeader}`
+ `${lineBreak}${openCheckbox}${timingDashboardVerification}`
+ `${lineBreak}${openCheckbox}${firebaseVerification}`
+ `${lineBreak}${openCheckbox}${ghVerification}`
+ `${lineBreakDouble}${ccApplauseLeads}`,
);
})
Expand All @@ -532,6 +541,7 @@ describe('GithubUtils', () => {
+ `${lineBreakDouble}${deployerVerificationsHeader}`
+ `${lineBreak}${openCheckbox}${timingDashboardVerification}`
+ `${lineBreak}${openCheckbox}${firebaseVerification}`
+ `${lineBreak}${openCheckbox}${ghVerification}`
+ `${lineBreakDouble}${ccApplauseLeads}`,
);
})
Expand All @@ -553,6 +563,7 @@ describe('GithubUtils', () => {
+ `${lineBreakDouble}${deployerVerificationsHeader}`
+ `${lineBreak}${openCheckbox}${timingDashboardVerification}`
+ `${lineBreak}${openCheckbox}${firebaseVerification}`
+ `${lineBreak}${openCheckbox}${ghVerification}`
+ `${lineBreakDouble}${ccApplauseLeads}`,
);
})
Expand Down

0 comments on commit 4a8bce9

Please sign in to comment.