Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update google terraform version, replace container registry by artifact registry #2902

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

swapkh91
Copy link

@swapkh91 swapkh91 commented Jan 8, 2025

Reference Issues or PRs

Fixes #2894

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

  • Setup nebari on GCP as per the docs
  • The deployment will fail at step module.registry-jupyterhub
  • Update hashicorp/google version in stages/02-infrastructure/gcp/versions.tf and stages/01-terraform-state/gcp/main.tf to 6.14.1
  • Change stages/02-infrastructure/gcp/modules/registry/main.tf to
resource "google_artifact_registry_repository" "registry" {
  location = <region as selected in init phase>
  format = "DOCKER"
  repository_id = <nebari-project-name>-dev
}
  • Run nebari deploy -c nebari-config.yaml --disable-render

Any other comments?

@swapkh91
Copy link
Author

swapkh91 commented Jan 8, 2025

@dcmcand @viniciusdc i've opened the PR as per my novice understanding, please review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New 🚦
Development

Successfully merging this pull request may close these issues.

Deploy and upgrade nebari on GCP fails because provider needs updated
2 participants