Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#Vulcan-132/Clear parameter value of Parameter select chart on tab change #617

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

m-o-n-i-s-h
Copy link
Contributor

Problem
Parameter select reports allow interactivity as users can select parameters/values from the autocomplete dropdown. When a parameter is selected, the selection stays active until the browser tab (that is, the dashboard) is closed, no matter if the dashboard tab is changed. So, my users wanted a functionality to set the parameter select chart type that gets cleared when there is a tab change.

Solution
Introduced a clearParameterValueOnTabChange boolean in settings. When this is enabled the value in the parameter is set to empty.

Screenshot
clear parameter value on tab change

NOTICE:
The program was tested solely for our own use cases, which might differ from yours.
Author Info: Monish [email protected] on behalf of Mercedes-Benz Research and Development India
https://github.com/mercedes-benz/mercedes-benz-foss/blob/master/PROVIDER_INFORMATION.md

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 46.27%. Comparing base (19b7538) to head (9cfa64e).
Report is 45 commits behind head on develop.

❗ Current head 9cfa64e differs from pull request most recent head 9a5d82c. Consider uploading reports for the commit 9a5d82c to get more accurate results

Files Patch % Lines
src/chart/parameter/ParameterSelectionChart.tsx 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #617      +/-   ##
===========================================
+ Coverage    37.49%   46.27%   +8.77%     
===========================================
  Files          216      166      -50     
  Lines         9140     6596    -2544     
  Branches      2703     2042     -661     
===========================================
- Hits          3427     3052     -375     
+ Misses        5654     3503    -2151     
+ Partials        59       41      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m-o-n-i-s-h m-o-n-i-s-h changed the title VULCAN-132/Clear parameter value of Parameter select chart on tab change #Vulcan-132/Clear parameter value of Parameter select chart on tab change Sep 29, 2023
@nielsdejong nielsdejong added the 2.3 label Nov 2, 2023
@nielsdejong nielsdejong removed the 2.4 label Nov 10, 2023
@alfredorubin96
Copy link
Collaborator

Hello @m-o-n-i-s-h, i see that you have a code smell from your SonarCloud, but i can't open it. Could you please check it?

@nielsdejong nielsdejong removed the 2.4.6 label Apr 26, 2024
Copy link

sonarqubecloud bot commented May 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@m-o-n-i-s-h
Copy link
Contributor Author

@alfredorubin96 addressed the code smell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants