-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#Vulcan-132/Clear parameter value of Parameter select chart on tab change #617
base: develop
Are you sure you want to change the base?
#Vulcan-132/Clear parameter value of Parameter select chart on tab change #617
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #617 +/- ##
===========================================
+ Coverage 37.49% 46.27% +8.77%
===========================================
Files 216 166 -50
Lines 9140 6596 -2544
Branches 2703 2042 -661
===========================================
- Hits 3427 3052 -375
+ Misses 5654 3503 -2151
+ Partials 59 41 -18 ☔ View full report in Codecov by Sentry. |
Hello @m-o-n-i-s-h, i see that you have a code smell from your SonarCloud, but i can't open it. Could you please check it? |
…TabChange-neodashpr merging latest code
Quality Gate failedFailed conditions |
@alfredorubin96 addressed the code smell. |
Problem
Parameter select reports allow interactivity as users can select parameters/values from the autocomplete dropdown. When a parameter is selected, the selection stays active until the browser tab (that is, the dashboard) is closed, no matter if the dashboard tab is changed. So, my users wanted a functionality to set the parameter select chart type that gets cleared when there is a tab change.
Solution
Introduced a clearParameterValueOnTabChange boolean in settings. When this is enabled the value in the parameter is set to empty.
Screenshot
NOTICE:
The program was tested solely for our own use cases, which might differ from yours.
Author Info: Monish [email protected] on behalf of Mercedes-Benz Research and Development India
https://github.com/mercedes-benz/mercedes-benz-foss/blob/master/PROVIDER_INFORMATION.md