cleaning code

src/application/ApplicationThunks.ts

@@ -47,7 +47,6 @@
 import { applicationGetLoggingSettings } from './logging/LoggingSelectors';
 import { createLogThunk } from './logging/LoggingThunk';
 import { createUUID } from '../utils/uuid';
-import { Neo4jConnectionModule } from '../connection/neo4j/Neo4jConnectionModule';
 import { QueryCallback, QueryParams } from '../connection/interfaces';
 import { getConnectionModule } from '../connection/utils';
 
@@ -264,12 +263,12 @@
       if (urlParams.get('credentials')) {
         setWelcomeScreenOpen(false);
         const connection = decodeURIComponent(urlParams.get('credentials'));
         const protocol = connection.split('://')[0];
         const username = connection.split('://')[1].split(':')[0];
         const password = connection.split('://')[1].split(':')[1].split('@')[0];
         const database = connection.split('@')[1].split(':')[0];
         const url = connection.split('@')[1].split(':')[1];
         const port = connection.split('@')[1].split(':')[2];
         // if (url == password) {
         //   // Special case where a connect link is generated without a password.
         //   // Here, the format is parsed incorrectly and we open the connection window instead.
@@ -576,7 +575,7 @@
       dispatch(initializeApplicationAsEditorThunk(config, paramsToSetAfterConnecting));
     }
   } catch (e) {
     console.log(e);
     dispatch(setWelcomeScreenOpen(false));
     dispatch(
       createNotificationThunk(

src/chart/parameter/ParameterSelectCardSettings.tsx

@@ -8,8 +8,6 @@
 import { Dropdown } from '@neo4j-ndl/react';
 import NeoCodeEditorComponent from '../../component/editor/CodeEditorComponent';
 import { QueryCallback, QueryParams, QueryStatus } from '../../connection/interfaces';
-import { Neo4jConnectionModule } from '../../connection/neo4j/Neo4jConnectionModule';
-import { getConnectionModule } from '../../connection/utils';
 import { useConnectionModuleContext } from '../../application/Application';
 
 type ParameterId = string | undefined | null;
@@ -80,7 +78,7 @@
           status == QueryStatus.NO_DATA ? setRecords([]) : () => {};
         },
         setRecords,
         setFields: () => {},
         setSchema: () => {},
       };
 

src/connection/ConnectionModule.ts

@@ -1,7 +1,5 @@
-import { createContext, useContext } from 'react';
-
 const notImplementedError = (functionName: string): never => {
   throw new Error(`Not Implemented: ${functionName}`);
 };
 
 export abstract class ConnectionModule {
@@ -11,24 +9,24 @@
     this.name = name;
   }
 
   authenticate(_credentials: Record<any, any>): void | never {
     return notImplementedError('authenticate');
   }
 
-  loadDashboard(_id: string): any | never {
+  loadDashboard(_id: string): any {
     return notImplementedError('loadDashboard');
   }
 
   saveDashboard(_dashboard: any): boolean | never {
     return notImplementedError('saveDashboard');
   }
 
   deleteDashboard(_id: string): void | never {
     return notImplementedError('deleteDashboard');
   }
 
   async runQuery(_driver, _queryParams: Record<string, any>, _queryCallbacks: Record<string, any>): Promise<void> {
     return notImplementedError('runQuery');
   }
 
   /**
@@ -36,13 +34,11 @@
    * @param records
    * @returns
    */
   parseRecords(_records: any[]): Record<any, any>[] {
     return notImplementedError('parseRecords');
   }
 }
 
 export interface ConnectionModuleState {
   connectionModule: ConnectionModule;
 }
-
-export declare const ConnectionModuleContext: import('react').Context<ConnectionModuleState>;

src/connection/neo4j/Neo4jConnectionModule.ts

@@ -3,29 +3,34 @@
 import { runCypherQuery } from './runCypherQuery';
 import { extractQueryCallbacks, extractQueryParams } from './utils';
 
+const notImplementedError = (functionName: string): never => {
+  throw new Error(`Not Implemented: ${functionName}`);
+};
+
 export class Neo4jConnectionModule extends ConnectionModule {
-  constructor(name) {
-    super(name);
+  authenticate(_credentials: Record<any, any>): void | never {
+    return notImplementedError('authenticate');
   }
 
-  authenticate(_credentials: Record<any, any>): void | never {}
-
-  async runQuery(driver, inputQueryParams, inputQuerycallbacks): Promise<void> {
+  async runQuery(driver, inputQueryParams, inputQueryCallbacks): Promise<void> {
     let queryParams = extractQueryParams(inputQueryParams);
-    let callbacks = extractQueryCallbacks(inputQuerycallbacks);
+    let callbacks = extractQueryCallbacks(inputQueryCallbacks);
     return runCypherQuery({ driver, ...queryParams, ...callbacks });
   }
 
-  loadDashboard(_id: string): any | never {}
+  loadDashboard(_id: string): any | never {
+    return notImplementedError('loadDashboard');
+  }
 
   saveDashboard(_dashboard: any): boolean | never {
-    return true;
+    return notImplementedError('saveDashboard');
   }
 
-  deleteDashboard(_id: string): void | never {}
+  deleteDashboard(_id: string): void | never {
+    return notImplementedError('deleteDashboard');
+  }
 
-  // TODO: understand how to implement it using only JS objects
   parseRecords(records: Neo4jRecord[]): any | never {
     return records;
   }
 }

src/connection/neo4j/runCypherQuery.ts

@@ -3,20 +3,9 @@
   extractNodeAndRelPropertiesFromRecords,
   extractNodePropertiesFromRecords,
 } from '../../report/ReportRecordProcessing';
+import { QueryStatus } from '../interfaces';
 import { setErrorDummy, setFieldsDummy, setRecordsDummy, setSchemaDummy, setStatusDummy } from './utils';
 
-export enum QueryStatus {
-  NO_QUERY, // No query specified
-  NO_DATA, // No data was returned, therefore we can't draw it.
-  NO_DRAWABLE_DATA, // There is data returned, but we can't draw it
-  WAITING, // The report is waiting for custom logic to be executed.
-  RUNNING, // The report query is running.
-  TIMED_OUT, // Query has reached the time limit.
-  COMPLETE, // There is data returned, and we can visualize it all.
-  COMPLETE_TRUNCATED, // There is data returned, but it's too much so we truncate it.
-  ERROR, // Something broke, likely the cypher query is invalid.
-}
-
 // TODO: create a readOnly version of this method or inject a property
 /**
  * Runs a Cypher query using the specified driver.
@@ -138,7 +127,7 @@
       setStatus(QueryStatus.ERROR);
       // Process other errors.
       if (setRecords) {
         setError(e.message);
         setRecords([{ error: e.message }]);
       }
       transaction.rollback();