Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate non-nested update where #6110

Merged
merged 5 commits into from
Mar 26, 2025

Conversation

darrellwarde
Copy link
Contributor

Description

A supplement to #6109, this deprecates the previous location to give a clean migration from Version 6. Requires some TCK/integration tests.

Complexity

Complexity: Medium

Copy link

changeset-bot bot commented Mar 25, 2025

🦋 Changeset detected

Latest commit: d65136b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@neo4j/graphql Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@darrellwarde darrellwarde marked this pull request as ready for review March 26, 2025 15:02
@darrellwarde darrellwarde requested a review from angrykoala March 26, 2025 15:26
Copy link
Member

@angrykoala angrykoala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will probably cause some conflicts with 7.x, remember to update that branch and fix the conflicts

Comment on lines +5 to +8
The `where` field for nested update operations has been deprecated to be moved within the `update` input field.
The `where` in its deprecated location is a no-op for all nested operations apart from `update`.

For example, the following mutation is using the deprecated syntax:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This change needs to be updated in the migration guide for version 6 in the "deprecations" section

@darrellwarde darrellwarde merged commit 100a603 into neo4j:dev Mar 26, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants