Skip to content

Commit

Permalink
avcodec/mediacodec_wrapper: get api level via NDK method
Browse files Browse the repository at this point in the history
android_get_device_api_level() is a static inline before API level
29. It was implemented via __system_property_get(). We can do the
same thing, but I don't want to mess up with __system_property_get.

Signed-off-by: Zhao Zhili <[email protected]>
  • Loading branch information
quink-black committed Jan 11, 2023
1 parent 8f35ee8 commit 8586540
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions libavcodec/mediacodec_wrapper.c
Original file line number Diff line number Diff line change
Expand Up @@ -2513,6 +2513,21 @@ FFAMediaCodec* ff_AMediaCodec_createEncoderByType(const char *mime_type, int ndk
int ff_Build_SDK_INT(AVCodecContext *avctx)
{
int ret = -1;

#if __ANDROID_API__ >= 24
// android_get_device_api_level() is a static inline before API level 29.
// dlsym() might doesn't work.
//
// We can implement android_get_device_api_level() by
// __system_property_get(), but __system_property_get() has created a lot of
// troubles and is deprecated. So avoid using __system_property_get() for
// now.
//
// Hopy we can remove the conditional compilation finally by bumping the
// required API level.
//
ret = android_get_device_api_level();
#else
JNIEnv *env = NULL;
jclass versionClass;
jfieldID sdkIntFieldID;
Expand All @@ -2522,5 +2537,8 @@ int ff_Build_SDK_INT(AVCodecContext *avctx)
sdkIntFieldID = (*env)->GetStaticFieldID(env, versionClass, "SDK_INT", "I");
ret = (*env)->GetStaticIntField(env, versionClass, sdkIntFieldID);
(*env)->DeleteLocalRef(env, versionClass);
#endif
av_log(avctx, AV_LOG_DEBUG, "device api level %d\n", ret);

return ret;
}

0 comments on commit 8586540

Please sign in to comment.