Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #6008:improve the home section of neo frontend #6020

Merged
merged 4 commits into from
Oct 8, 2024
Merged

fix #6008:improve the home section of neo frontend #6020

merged 4 commits into from
Oct 8, 2024

Conversation

TusharMohapatra07
Copy link
Contributor

@TusharMohapatra07 TusharMohapatra07 commented Oct 6, 2024

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the main branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

Other information:
This PR is linked with issue #6008. I have improved the look of the neo homepage by making the tagline significantly big such that it won't go unnoticed. Also, I've added a background pattern which complements the look of homepage.

@tobiu
Copy link
Collaborator

tobiu commented Oct 7, 2024

hi @TusharMohapatra07,

the design-changes look good. One very important requirement, before i can accept & merge this PR:
please do not change the default formatting, otherwise it becomes very hard to spot for others what changed.

Meaning: 4 spaces & block formatting (align on colon). You can just add another commit to this PR (no need for a new one) and I will accept it afterwards.

Ideas for a follow-up PR: we could switch the h1 & h2 tags (h2 for the logo-text, h1 for the tag-line) => can be easily done inside the matching JS file.

We do have CSS vars for font-weight:

font-weight: var(--core-fontweight-semibold);

There is also one for bold (I think it equals 700 instead of 800). var(--core-fontweight-bold);

Best regards,
Tobi

@tobiu tobiu added the hacktoberfest related to the event => https://hacktoberfest.com/ label Oct 7, 2024
@TusharMohapatra07
Copy link
Contributor Author

TusharMohapatra07 commented Oct 8, 2024

@tobiu please review. Also, I'll be follow-up PR that You're talking about.

@tobiu
Copy link
Collaborator

tobiu commented Oct 8, 2024

you hopefully know that you can review the changes too:
https://github.com/neomjs/neo/pull/6020/files

you got the 4 spaces indentation in there now, which is good. the align on colon part is missing, but i will fix it.

hacktoberfest approved.

@tobiu tobiu merged commit df3ba85 into neomjs:dev Oct 8, 2024
@TusharMohapatra07
Copy link
Contributor Author

@tobiu i think the commit named "fix spacing" with hash 85ad0ff did that but then i thought it was wrong.

@TusharMohapatra07
Copy link
Contributor Author

TusharMohapatra07 commented Oct 8, 2024

By the way, thanks @tobiu for your patience and time. You were such welcoming and supportive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest related to the event => https://hacktoberfest.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants