feat: Support custom metadata property #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alphaho
force-pushed
the
feature/metadata
branch
from
5bf89c3 to
6d58c44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to solve #34 with a generic metadata property in the
Constraintclass, while keeping the backward compatibility as much as possible by defining type aliases forContraint/Validatable. But haven't made the type alias forRunner's subclasses yet.On the ktor integration, it still uses the default metadata type, as the Exception class can not be generic. It may need some more work to make it accept different types for metadata if we want.
@nesk Do you think it's a good idea to add the metadata support like this? Or there's something else in your mind?
If you think it's the right way to do, I can carry on and refine the PR further.