fix: Handle OpenAI API errors (chatwoot#9560)

app/controllers/api/v1/accounts/integrations/hooks_controller.rb

@@ -11,7 +11,12 @@ def update
  end
 
  def process_event
- render json: { message: @hook.process_event(params[:event]) }
+ response = @hook.process_event(params[:event])
+ if response[:error]
+ render json: { error: response[:error] }, status: :unprocessable_entity
+ else
+ render json: { message: response[:message] }
+ end
  end
 
  def destroy

app/javascript/dashboard/mixins/aiMixin.js

@@ -100,7 +100,11 @@ export default {
  } = result;
  return generatedMessage;
  } catch (error) {
- useAlert(this.$t('INTEGRATION_SETTINGS.OPEN_AI.GENERATE_ERROR'));
+ const errorData = error.response.data.error;
+ const errorMessage =
+ errorData?.error?.message ||
+ this.$t('INTEGRATION_SETTINGS.OPEN_AI.GENERATE_ERROR');
+ useAlert(errorMessage);
  return '';
  }
  },

app/models/integrations/hook.rb

@@ -56,7 +56,7 @@ def process_event(event)
  when 'openai'
  Integrations::Openai::ProcessorService.new(hook: self, event: event).perform if app_id == 'openai'
  else
- 'No processor found'
+ { error: 'No processor found' }
  end
  end
 

enterprise/lib/enterprise/integrations/openai_processor_service.rb

@@ -31,7 +31,7 @@ def label_suggestion_message
  # To what you ask? Sometimes, the response includes
  # "Labels:" in it's response in some format. This is a hacky way to remove it
  # TODO: Fix with with a better prompt
- response.present? ? response.gsub(/^(label|labels):/i, '') : ''
+ response[:message] ? response[:message].gsub(/^(label|labels):/i, '') : ''
  end
 
  private

lib/integrations/openai_base_service.rb

@@ -77,8 +77,12 @@ def make_api_call(body)
  response = HTTParty.post(API_URL, headers: headers, body: body)
  Rails.logger.info("OpenAI API response: #{response.body}")
 
+ return { error: response.parsed_response, error_code: response.code } unless response.success?
+
  choices = JSON.parse(response.body)['choices']
 
- choices.present? ? choices.first['message']['content'] : nil
+ return { message: choices.first['message']['content'] } if choices.present?
+
+ { message: nil }
  end
 end

spec/controllers/api/v1/accounts/integrations/hooks_controller_spec.rb

@@ -97,9 +97,8 @@
  params: params,
  headers: agent.create_new_auth_token,
  as: :json
-
- expect(response).to have_http_status(:success)
- expect(response.parsed_body['message']).to eq('No processor found')
+ expect(response).to have_http_status(:unprocessable_entity)
+ expect(response.parsed_body['error']).to eq 'No processor found'
  end
  end
  end

spec/lib/integrations/openai/processor_service_spec.rb

@@ -52,7 +52,7 @@
  .to_return(status: 200, body: openai_response, headers: {})
 
  result = subject.perform
- expect(result).to eq('This is a reply from openai.')
+ expect(result).to eq({ :message => 'This is a reply from openai.' })
  end
  end
 
@@ -76,7 +76,7 @@
  .to_return(status: 200, body: openai_response, headers: {})
 
  result = subject.perform
- expect(result).to eq('This is a reply from openai.')
+ expect(result).to eq({ :message => 'This is a reply from openai.' })
  end
  end
 
@@ -101,7 +101,7 @@
  .to_return(status: 200, body: openai_response, headers: {})
 
  result = subject.perform
- expect(result).to eq('This is a reply from openai.')
+ expect(result).to eq({ :message => 'This is a reply from openai.' })
  end
  end
 
@@ -140,7 +140,7 @@
  .to_return(status: 200, body: openai_response, headers: {})
 
  result = subject.perform
- expect(result).to eq('This is a reply from openai.')
+ expect(result).to eq({ :message => 'This is a reply from openai.' })
  end
  end
 
@@ -162,7 +162,7 @@
  .to_return(status: 200, body: openai_response, headers: {})
 
  result = subject.perform
- expect(result).to eq('This is a reply from openai.')
+ expect(result).to eq({ :message => 'This is a reply from openai.' })
  end
  end
 
@@ -184,7 +184,7 @@
  .to_return(status: 200, body: openai_response, headers: {})
 
  result = subject.perform
- expect(result).to eq('This is a reply from openai.')
+ expect(result).to eq({ :message => 'This is a reply from openai.' })
  end
  end
 
@@ -206,7 +206,7 @@
  .to_return(status: 200, body: openai_response, headers: {})
 
  result = subject.perform
- expect(result).to eq('This is a reply from openai.')
+ expect(result).to eq({ :message => 'This is a reply from openai.' })
  end
  end
 
@@ -228,7 +228,7 @@
  .to_return(status: 200, body: openai_response, headers: {})
 
  result = subject.perform
- expect(result).to eq('This is a reply from openai.')
+ expect(result).to eq({ :message => 'This is a reply from openai.' })
  end
  end
 
@@ -250,7 +250,7 @@
  .to_return(status: 200, body: openai_response, headers: {})
 
  result = subject.perform
- expect(result).to eq('This is a reply from openai.')
+ expect(result).to eq({ :message => 'This is a reply from openai.' })
  end
  end
  end

spec/models/integrations/hook_spec.rb

@@ -37,7 +37,7 @@
 
  it 'returns no processor found for hooks with out processor defined' do
  hook = create(:integrations_hook, account: account)
- expect(hook.process_event(params)).to eq('No processor found')
+ expect(hook.process_event(params)).to eq({ :error => 'No processor found' })
  end
 
  it 'returns results from procesor for openai hook' do