-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat: Add streaming support #125
Conversation
Fixed event listener oddities, working input detach/attach on pointer lock change, formatting and adding proper key+mouse codes for Linux and moving them into separate file. Co-authored-by: Kristian Ollikainen <[email protected]>
Deploying nestri with Cloudflare Pages
|
I've finished cooking 🍝 --------- Co-authored-by: DatCaptainHorse <[email protected]>
…ging (#129) Adds a functional NESTRI_PARAMS env variable to container image, allowing usage like: ```docker run -e NESTRI_PARAMS='--no-audio=true --verbose=true'``` Also adds a no-audio option to help debug stream issues. Also also, changes the container builder portion to use the actual main nestri repo. --------- Co-authored-by: DatCaptainHorse <[email protected]>
I just added the first part of handling websockets thru a relay, partykit It works locally, i have yet to deploy the server side end of things FIXME: I think I overwrote the changes done by DatHorse in the prior branch :(
UPDATE: This was scraped, too much overhead :/ |
… WHIP output (#130) I feel things can be improved still, however rather than making perfect CLI parameter handling, gonna PR to help move on. WHIP output option added for starters, we may need to write our own WebRTC element based off examples and API from: https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/tree/main/net/webrtc --------- Co-authored-by: DatCaptainHorse <[email protected]> Co-authored-by: Wanjohi <[email protected]>
This reverts commit a975b89.
- Adds heartbeat to keep WS alive on nestri-server side - Fixes inputs getting stuck on repeated keys, while also allowing modifiers to be sent after. - For now treat Home keys as Esc to make games escapable. - Add button to start stream, to fix browser preventing play issue. Co-authored-by: DatCaptainHorse <[email protected]>
This adds functionality to: 1. Broadcast input to the server using WebRTC Data Channels 2. Change some terms for easy understanding `stream -> room`, `viewer => participant` 3. Remove input functionality currently relying on Cloudflare's D3 and move it to our relay --------- Co-authored-by: Kristian Ollikainen <[email protected]> Co-authored-by: DatCaptainHorse <[email protected]>
Update
|
…er files (#136) Co-authored-by: DatCaptainHorse <[email protected]>
TODO It has been reported that input has a lot of latency, there might be many causes of this but here's my two cents:
|
…tor connection (#137) Using the same WebRTC connection as DataChannel inputs, though switched it to WHIP etc. Draft since I'm still looking into some stuff. --------- Co-authored-by: DatCaptainHorse <[email protected]>
Add latency trackers, tidy things into separate files, improve code behaviour all around but especially in `nestri-server`, removal of buffering and usage of mutex locking allows to push 120FPS easily again. Time to see if DOOM is now playable with the hugely increased responsiveness.. --------- Co-authored-by: DatCaptainHorse <[email protected]>
@wanjohiryan Can I ask you why QUIC was dropped? I'm just curious, I was taking a look to Rust projects using any kind of moq |
Hello 👋🏾 @Blast545 We dropped MoQ temporarily because it was slowing us down - it is not mature yet. For example; audio is not working as expected. It is choppy, and when it is not choppy - it is mono channel. Also, it has very limited support on Firefox and Safari. (Webcodecs and Webtransport have very limited browser support)... WebRTC on the other hand is more widely supported. I am not against MoQ, and I hope when we get Nestri out of the door, we will come back and help out where we can. But for now we will be going with the more mature WebRTC |
Thanks for your answer! I was getting the same feeling when I tried MoQ a week ago |
This adds:
Update - 17/11