Skip to content

Commit

Permalink
provider/azurerm: Public IP - Setting idle timeout value caused panic. (
Browse files Browse the repository at this point in the history
hashicorp#8283)

Setting the idle_timeout_in_minutes value of the azurerm_public_ip
resource always caused a panic.

This fixes it and adds a test to actually test that particular
attribute.
  • Loading branch information
kristinn authored and stack72 committed Aug 18, 2016
1 parent c3e46a1 commit 7f096a6
Show file tree
Hide file tree
Showing 2 changed files with 40 additions and 1 deletion.
2 changes: 1 addition & 1 deletion builtin/providers/azurerm/resource_arm_public_ip.go
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ func resourceArmPublicIpCreate(d *schema.ResourceData, meta interface{}) error {
}

if v, ok := d.GetOk("idle_timeout_in_minutes"); ok {
idle_timeout := v.(int32)
idle_timeout := int32(v.(int))
properties.IdleTimeoutInMinutes = &idle_timeout
}

Expand Down
39 changes: 39 additions & 0 deletions builtin/providers/azurerm/resource_arm_public_ip_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,31 @@ func TestAccAzureRMPublicIpStatic_basic(t *testing.T) {
})
}

func TestAccAzureRMPublicIpStatic_idleTimeout(t *testing.T) {

ri := acctest.RandInt()
config := fmt.Sprintf(testAccAzureRMVPublicIpStatic_idleTimeout, ri, ri)

resource.Test(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders,
CheckDestroy: testCheckAzureRMPublicIpDestroy,
Steps: []resource.TestStep{
resource.TestStep{
Config: config,
Check: resource.ComposeTestCheckFunc(
testCheckAzureRMPublicIpExists("azurerm_public_ip.test"),
resource.TestCheckResourceAttr(
"azurerm_public_ip.test",
"idle_timeout_in_minutes",
"30",
),
),
},
},
})
}

func TestAccAzureRMPublicIpStatic_withTags(t *testing.T) {

ri := acctest.RandInt()
Expand Down Expand Up @@ -267,6 +292,20 @@ resource "azurerm_public_ip" "test" {
}
`

var testAccAzureRMVPublicIpStatic_idleTimeout = `
resource "azurerm_resource_group" "test" {
name = "acctestrg-%d"
location = "West US"
}
resource "azurerm_public_ip" "test" {
name = "acctestpublicip-%d"
location = "West US"
resource_group_name = "${azurerm_resource_group.test.name}"
public_ip_address_allocation = "static"
idle_timeout_in_minutes = 30
}
`

var testAccAzureRMVPublicIpDynamic_basic = `
resource "azurerm_resource_group" "test" {
name = "acctestrg-%d"
Expand Down

0 comments on commit 7f096a6

Please sign in to comment.