Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rebalance test suite #5972

Merged
merged 7 commits into from
Jan 2, 2025
Merged

test: rebalance test suite #5972

merged 7 commits into from
Jan 2, 2025

Conversation

mrstork
Copy link
Contributor

@mrstork mrstork commented Dec 30, 2024

Summary

  • Run npm run test:measure to rebalance the test suite (Resolves Missing test metadata for ... warnings)
  • Remove manual setup for test parallelism, leverage ava default settings instead
    • Opted for a non-custom solution to balance the tests to make maintenance easier
  • Remove tools package
  • Fix bug with ava test distribution in github workflow

Tests are now better balanced across test runners

Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@mrstork mrstork force-pushed the rebalance-tests branch 4 times, most recently from 224f998 to a3c4215 Compare December 30, 2024 21:46
@@ -198,7 +198,7 @@ jobs:
env:
# split tests across multiple machines
CI_NODE_INDEX: ${{ matrix.machine }}
CI_NODE_TOTAL: 4
CI_NODE_TOTAL: 5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches the number of machines from line 128 (i.e. machine: ['0', '1', '2', '3', '4'])

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -2,7 +2,7 @@ import baseConfig from '../../ava.base.js'

const config = {
...baseConfig,
files: ['tests/*.{cjs,mjs,js}', 'tests/**/tests.{cjs,mjs,js}'],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This first glob is no longer used

@mrstork mrstork marked this pull request as ready for review December 31, 2024 15:56
@mrstork mrstork requested a review from a team as a code owner December 31, 2024 15:56
@mrstork mrstork marked this pull request as draft January 1, 2025 00:21
@mrstork mrstork marked this pull request as ready for review January 2, 2025 01:56
@mrstork mrstork added this pull request to the merge queue Jan 2, 2025
Merged via the queue into main with commit 314ce08 Jan 2, 2025
33 checks passed
@mrstork mrstork deleted the rebalance-tests branch January 2, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants