perf: speed up all commands by 75+ ms by enabling V8 code cache when available (node>=22.8.0)
#7173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our minimum supported version is 18, so we need to rely on node 18 types.
serhalp
commented
Apr 8, 2025
| @@ -203,7 +204,6 @@ | |||
| "eslint-config-prettier": "^10.1.1", | |||
| "eslint-plugin-n": "^17.16.1", | |||
| "form-data": "4.0.2", | |||
| "is-ci": "4.1.0", | |||
serhalp
commented
Apr 8, 2025
| "@types/node": "22.13.10", | ||
| "@types/node": "18.19.86", |
There was a problem hiding this comment.
This was incorrectly upgraded. We support min. 18 so we need v18 types.
serhalp
commented
Apr 8, 2025
serhalp
commented
Apr 8, 2025
serhalp
commented
Apr 8, 2025
The `preAction` hook was overwriting the whole payload, so any prior calls to `setAnalyticsPayload` would have their data thrown away. This didn't matter, but I'd like to introduce an early call.
See https://nodejs.org/api/module.html#module-compile-cache. In local benchmarking on various machines, this led to a 75-400 ms improvement to command run time across the board, at the expense of a moderate increase in first-time run time. See inline - to account for the common CI single-run use case, this is disabled when we detect a CI environment.
serhalp
commented
Apr 8, 2025
serhalp
commented
Apr 8, 2025
serhalp
commented
Apr 8, 2025
serhalp
changed the title
serhalp
changed the title
node>=22.8.0)
ndhoule
requested changes
Apr 8, 2025
This also removes the child process handling.
ndhoule
approved these changes
Apr 8, 2025
|
🐎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See https://nodejs.org/api/module.html#module-compile-cache.
In local benchmarking on various machines, this led to a 75-400 ms improvement to command run time across the board, at the expense of a moderate increase in first-time run time.
See inline - to account for the common CI single-run use case, this is disabled when we detect a CI environment.
See individual commits for context on the other changes here.