fix: fix framework server loading spinner ("Waiting for framework port") #7242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhalp
commented
Apr 28, 2025
| @@ -68,7 +68,7 @@ export const startFrameworkServer = async function ({ | |||
| throw new Error(`Timed out waiting for port '${settings.frameworkPort}' to be open`) | |||
| } | |||
| } | |||
| stopSpinner({ error: false, spinner }) | |||
| spinner.success() | |||
There was a problem hiding this comment.
We want to draw the ✔️, not erase it
serhalp
force-pushed
the
fix/spinner-7124
branch
from
5a2e430 to
7a7bbde
Compare
serhalp
commented
May 1, 2025
| spinner.clear() | ||
| } | ||
| // Clear the spinner, write the framework command line, then resume spinning | ||
| spinner?.clear() | ||
| writeStream.write(chunk, () => { | ||
| spinner?.spin() |
There was a problem hiding this comment.
I believe this still isn't quite right — spin() renders a single frame, but here we want to keep looping even when we aren't receiving chunks from the framework server.
But this fix is worth getting in now and I'll follow up when I get the full fix working.
There was a problem hiding this comment.
(In that follow-up I'll also look into how we can add test coverage for this)
This is a regression in the loading spinner shown before "Waiting for framework port", introduced in 19.0.3.
See: 1. #7026 2. #7131 3. #7124 Oops, I was really overthinking this. All this needs to do is, every time a chunk comes in from the underlying framework dev server, clear the spinner line, write the chunk, then resume the spinner. This wasn't set up right at all, which was obfuscated by the erroneous use of `isSpinning` (see previous commit).
sarahetter
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a regression in the loading spinner shown before "Waiting for framework port", introduced in 19.0.3.
See:
oraandlog-symbolswith tiny dependencynanospinner#7026Oops, I was really overthinking this. All this needs to do is, every time a chunk comes in from the underlying framework dev server, clear the spinner line, write the chunk, then resume the spinner.
This wasn't set up right at all, which was obfuscated by the erroneous use of
isSpinning.Fixes #7124.
Thank you @Florian-Mt for spotting the (embarrassing!) fix.
Before
After