wip

neuhaus · Nov 5, 2017 · d833cd9 · d833cd9
1 parent a7d4f88
commit d833cd9
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 16 deletions.
diff --git a/examples/php/arbitrage-pairs.php b/examples/php/arbitrage-pairs.php
@@ -2,7 +2,7 @@
 
 $root = dirname (dirname (dirname (__FILE__)));
 
-include $root . '/build/ccxt.php';
+include $root . '/ccxt.php';
 include 'Console/Table.php';
 
 date_default_timezone_set ('UTC');

diff --git a/js/base/Exchange.js b/js/base/Exchange.js
@@ -428,15 +428,15 @@ module.exports = class Exchange {
         throw new NotSupported (this.id + ' fetchOrder not supported yet');
     }
 
-    fetchOrders (symbol = undefined, params = {}) {
+    fetchOrders (symbol = undefined, since = undefined, limit = undefined, params = {}) {
         throw new NotSupported (this.id + ' fetchOrders not supported yet');
     }
 
-    fetchOpenOrders (symbol = undefined, params = {}) {
+    fetchOpenOrders (symbol = undefined,$since = undefined, limit = undefined, params = {}) {
         throw new NotSupported (this.id + ' fetchOpenOrders not supported yet');
     }
 
-    fetchClosedOrders (symbol = undefined, params = {}) {
+    fetchClosedOrders (symbol = undefined, since = undefined, limit = undefined, params = {}) {
         throw new NotSupported (this.id + ' fetchClosedOrders not supported yet');
     }
 

diff --git a/php/base/Exchange.php b/php/base/Exchange.php
@@ -879,7 +879,7 @@ public function parse_bid_ask ($bidask, $price_key = 0, $amount_key = 0) {
         return array (floatval ($bidask[$price_key]), floatval ($bidask[$amount_key]));
     }
 
-    public function parse_bid_asks ($bidasks, $price_key = 0, $amount_key = 0) {
+    public function parse_bids_asks ($bidasks, $price_key = 0, $amount_key = 0) {
         $result = array ();
         $array = array_values ($bidasks);
         foreach ($array as $bidask)
@@ -1034,31 +1034,31 @@ public function fetchOrder ($id, $symbol = null, $params = array ()) {
         return $this->fetch_order ($id, $symbol, $params);
     }
 
-    public function fetch_orders ($symbol = null, $params = array ()) {
+    public function fetch_orders ($symbol = null, $since = null, $limit = null, $params = array ()) {
         $exception = '\\ccxt\\NotSupported';
         throw new $exception ($this->id . ' fetch_orders() not implemented yet');
     }
 
-    public function fetchOrders ($symbol = null, $params = array ()) {
-        return $this->fetch_orders ($symbol, $params);
+    public function fetchOrders ($symbol = null, $since = null, $limit = null, $params = array ()) {
+        return $this->fetch_orders ($symbol, $since, $limit, $params);
     }
 
-    public function fetch_open_orders ($symbol = null, $params = array ()) {
+    public function fetch_open_orders ($symbol = null, $since = null, $limit = null, $params = array ()) {
         $exception = '\\ccxt\\NotSupported';
         throw new $exception ($this->id . ' fetch_open_orders() not implemented yet');
     }
 
-    public function fetchOpenOrders ($symbol = null, $params = array ()) {
+    public function fetchOpenOrders ($symbol = null, $since = null, $limit = null, $params = array ()) {
         return $this->fetch_open_orders ($symbol, $params);
     }
 
-    public function fetch_closed_orders ($symbol = null, $params = array ()) {
+    public function fetch_closed_orders ($symbol = null, $since = null, $limit = null, $params = array ()) {
         $exception = '\\ccxt\\NotSupported';
         throw new $exception ($this->id . ' fetch_closed_orders() not implemented yet');
     }
 
-    public function fetchClosedOrders ($symbol = null, $params = array ()) {
-        return $this->fetch_closed_orders ($symbol, $params);
+    public function fetchClosedOrders ($symbol = null, $since = null, $limit = null, $params = array ()) {
+        return $this->fetch_closed_orders ($symbol, $since, $limit, $params);
     }
 
     public function fetch_my_trades ($symbol = null, $since = null, $limit = null, $params = array ()) {

diff --git a/python/ccxt/base/exchange.py b/python/ccxt/base/exchange.py
@@ -750,13 +750,13 @@ def fetch_order_status(self, id, market=None):
     def fetch_order(self, id, symbol=None, params={}):
         raise NotSupported(self.id + ' fetch_order() is not implemented yet')
 
-    def fetch_orders(self, symbol=None, params={}):
+    def fetch_orders(self, symbol=None, since=None, limit=None, params={}):
         raise NotSupported(self.id + ' fetch_orders() is not implemented yet')
 
-    def fetch_open_orders(self, symbol=None, params={}):
+    def fetch_open_orders(self, symbol=None, since=None, limit=None, params={}):
         raise NotSupported(self.id + ' fetch_open_orders() not implemented yet')
 
-    def fetch_closed_orders(self, symbol=None, params={}):
+    def fetch_closed_orders(self, symbol=None, since=None, limit=None, params={}):
         raise NotSupported(self.id + ' fetch_closed_orders() not implemented yet')
 
     def fetch_my_trades(self, symbol=None, since=None, limit=None, params={}):