Add ui code to guidellm #149
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am in the process of breaking up this massive PR into sub PRs that are more approachable for review and then will delete this PR
Todo:
Need to update the workflows. The current gh-pages workflow is an example that should be converted into something like ui-main.yaml ui-release-candidate.yaml ui-release.yaml. It will mirror these: https://github.com/neuralmagic/guidellm-ui/tree/main/.github/workflows except we will replace the build pipeline in there with one using gh-pages.
That plan hasn't been approved yet but it assumes we will utilize gh pages for hosting these frontend builds and that we will want the ability to have separate versioned builds for dev/staging/prod
Biggest open question is what is the state the frontend code needs to be in for an MVP to be ready to be merged. Is there any refining of standards or anything else that can't wait? Doesn't matter to me but the sooner we have standards the easier it will be to meet them in a timely manner.