Fix max number of tokens for synthetic data generator #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
prompt_tokens_max
(and not usingprompt_tokens_stdev
), there will occasionally be one token more than the maximum number specified. This can be tested as follows:The assertion will fire, despite the max being set to 15. This happens because
random.randint
, which is used byIntegerRangeSampler
, generates numbers up to and including the max value it is given. This PR fixes that.