Skip to content

Commit

Permalink
CachingClusteredClientTest: Use groupBy v1. (apache#3958)
Browse files Browse the repository at this point in the history
GroupBy v2 doesn't cache on the broker, so it isn't actually testing
what the test was supposed to be testing. Also, the test failed due
to mismatched expectations.
  • Loading branch information
gianm authored and pjain1 committed Feb 21, 2017
1 parent 128274c commit f910c05
Showing 1 changed file with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@
import io.druid.query.groupby.GroupByQuery;
import io.druid.query.groupby.GroupByQueryConfig;
import io.druid.query.groupby.GroupByQueryRunnerTest;
import io.druid.query.groupby.strategy.GroupByStrategySelector;
import io.druid.query.ordering.StringComparators;
import io.druid.query.search.SearchQueryQueryToolChest;
import io.druid.query.search.SearchResultValue;
Expand Down Expand Up @@ -158,7 +159,12 @@
@RunWith(Parameterized.class)
public class CachingClusteredClientTest
{
public static final ImmutableMap<String, Object> CONTEXT = ImmutableMap.<String, Object>of("finalize", false);
public static final ImmutableMap<String, Object> CONTEXT = ImmutableMap.<String, Object>of(
"finalize", false,

// GroupBy v2 won't cache on the broker, so test with v1.
"groupByStrategy", GroupByStrategySelector.STRATEGY_V1
);
public static final MultipleIntervalSegmentSpec SEG_SPEC = new MultipleIntervalSegmentSpec(ImmutableList.<Interval>of());
public static final String DATA_SOURCE = "test";
static final DefaultObjectMapper jsonMapper = new DefaultObjectMapper(new SmileFactory());
Expand Down

0 comments on commit f910c05

Please sign in to comment.