-
-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assistant design improvements + V2 API #3327
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Milen Pivchev <[email protected]>
…sistant-improvements
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
@mpivchev I think AI conversations are rarely “completed”. People often want to ask follow-up questions. This aligns better with the natural flow of human reasoning (where follow-up questions are common), therefore, should avoid “completed”mark.
What is the difference between API V1 (<NC30) and API V2 (>=NC30)? Is there any improvements or difference from API V1? |
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Thanks for the detailed info! It looks better and more useful now, with more functionalities. |
Hi @Hyeyoung346 the scrolling issue is already fixed in this PR. It's just open until this PR is merged :) |
Regarding 1. I'll see what I can do on Monday. Have a nice weekend 😀 |
…sistant-improvements
Signed-off-by: Milen Pivchev <[email protected]>
…sistant-improvements
Signed-off-by: Milen Pivchev <[email protected]>
@Hyeyoung346 modified the date to show in a more human readable way ![]()
I agree ultimately we should remove the status altogether and mimic a chat-like behavior. But for now, since it's just a prompt-style, we should keep it this way IMO. |
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
@jancborchardt can you quickly go over this :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a really nice improvement @mpivchev! :)
I only have 2 small details for now, but they are not necessarily blockers, could also be done in follow-ups:
- The vertical space between the 3 lines in the task list should be even (right now there is more space above the date)
- I agree the "Completed" text could be cut. The icon is fine enough. And in the detail view, if it is still pending or if there is an error, that should show more presently as a sort of empty content view where the Output would normally be.
Prerequisite: nextcloud/NextcloudKit#124
Some points @Hyeyoung346:
Server.sh
now includes the commands to enable that, so you can start a server using that script.