improve variable naming

Signed-off-by: Bjoern Schiessle <[email protected]>
nextcloud · Nov 30, 2018 · 34d4c2b · 34d4c2b
1 parent 8796c6b
commit 34d4c2b
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/apps/encryption/lib/Crypto/Crypt.php b/apps/encryption/lib/Crypto/Crypt.php
@@ -482,14 +482,14 @@ public function symmetricDecryptFileContent($keyFileContents, $passPhrase, $ciph
 	 * @throws GenericEncryptionException
 	 */
 	private function checkSignature($data, $passPhrase, $expectedSignature) {
-		$skipSignatureCheck = $this->config->getSystemValue('encryption_skip_signature_check', false);
+		$enforceSignature = !$this->config->getSystemValue('encryption_skip_signature_check', false);
 
 		$signature = $this->createSignature($data, $passPhrase);
-		$hash = hash_equals($expectedSignature, $signature);
+		$isCorrectHash = hash_equals($expectedSignature, $signature);
 
-		if (!$hash && $skipSignatureCheck === false) {
+		if (!$isCorrectHash && $enforceSignature) {
 			throw new GenericEncryptionException('Bad Signature', $this->l->t('Bad Signature'));
-		} else if (!$hash && $skipSignatureCheck) {
+		} else if (!$isCorrectHash && !$enforceSignature) {
 			$this->logger->info("Signature check skipped", ['app' => 'encryption']);
 		}
 	}