Update CSS for landscape mode #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this @Goutamchoudhary907! This does appear to be working better, however there still seems to be some strange behaviors with the scroll snapping Perhaps disabling scroll snapping all together when this page is in landscape mode would be a good fix for this?
|
|
Hey @nfoert Thanks for suggestion , i work on this and add some javascript to disable scroll snapping as css wont work , now there is no scroll snapping in landscape mode |
Landscape changes would be applied even if it wasn't displayed on a smaller screen
|
Thanks for working on this! There was one issue with the CSS media query which I fixed, the scroll snap was getting disabled on any landscape screen which includes normal computer screens, it needed to be on landscape and with a small display |
|
Thanks for merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #47
Hey , i just update css for landscape mode , plz check and let me know if anything else is needed , if not merge this PR