Skip to content

Commit

Permalink
build(project): fix-build-error (element-plus#1638)
Browse files Browse the repository at this point in the history
- Fix type caused build error which stops the type generator producing type files
  • Loading branch information
jw-foss authored Mar 15, 2021
1 parent f209197 commit ea9aa0d
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 9 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.en-US.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
- Fix table fix #1591 (#1593)
- Fix radio type order (#1554)
- Fix time-picker replace test `it.only` with `it` in test (#1586)
- Fix popper simplify mapEvents logic & add IEvents (#1541)
- Fix popper simplify mapEvents logic & add PopperEvents (#1541)
- Fix pagination component layout prop bug (#1576)
- Fix select disabled group not works (#1559)
- Fix dropdown dropdown will expand when unexpected (#1569)
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.es.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
- Fix table fix #1591 (#1593)
- Fix radio type order (#1554)
- Fix time-picker replace test `it.only` with `it` in test (#1586)
- Fix popper simplify mapEvents logic & add IEvents (#1541)
- Fix popper simplify mapEvents logic & add (#1541)
- Fix pagination component layout prop bug (#1576)
- Fix select disabled group not works (#1559)
- Fix dropdown dropdown will expand when unexpected (#1569)
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.fr-FR.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
- Fix table fix #1591 (#1593)
- Fix radio type order (#1554)
- Fix time-picker replace test `it.only` with `it` in test (#1586)
- Fix popper simplify mapEvents logic & add IEvents (#1541)
- Fix popper simplify mapEvents logic & add PopperEvents (#1541)
- Fix pagination component layout prop bug (#1576)
- Fix select disabled group not works (#1559)
- Fix dropdown dropdown will expand when unexpected (#1569)
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.jp.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
- Fix table fix #1591 (#1593)
- Fix radio type order (#1554)
- Fix time-picker replace test `it.only` with `it` in test (#1586)
- Fix popper simplify mapEvents logic & add IEvents (#1541)
- Fix popper simplify mapEvents logic & add PopperEvents (#1541)
- Fix pagination component layout prop bug (#1576)
- Fix select disabled group not works (#1559)
- Fix dropdown dropdown will expand when unexpected (#1569)
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.zh-CN.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
- Fix table fix #1591 (#1593)
- Fix radio type order (#1554)
- Fix time-picker replace test `it.only` with `it` in test (#1586)
- Fix popper simplify mapEvents logic & add IEvents (#1541)
- Fix popper simplify mapEvents logic & add PopperEvents (#1541)
- Fix pagination component layout prop bug (#1576)
- Fix select disabled group not works (#1559)
- Fix dropdown dropdown will expand when unexpected (#1569)
Expand Down
1 change: 0 additions & 1 deletion packages/pagination/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import {
ref,
computed,
watch,
nextTick,
provide,
} from 'vue'
import { IPagination } from './pagination'
Expand Down
6 changes: 3 additions & 3 deletions packages/popper/src/use-popper/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import type {
export type ElementType = ComponentPublicInstance | HTMLElement
export type EmitType = 'update:visible' | 'after-enter' | 'after-leave' | 'before-enter' | 'before-leave'

interface IEvents {
export interface PopperEvents {
onClick?: (e: Event) => void
onMouseenter?: (e: Event) => void
onMouseleave?: (e: Event) => void
Expand Down Expand Up @@ -173,7 +173,7 @@ export default function(
popperInstance = null
}

const events = {} as IEvents
const events = {} as PopperEvents

function update() {
if (!$(visibility)) {
Expand Down Expand Up @@ -235,7 +235,7 @@ export default function(
}
}

const triggerEventsMap: Partial<Record<TriggerType, (keyof IEvents)[]>> = {
const triggerEventsMap: Partial<Record<TriggerType, (keyof PopperEvents)[]>> = {
click: ['onClick'],
hover: ['onMouseenter', 'onMouseleave'],
focus: ['onFocus', 'onBlur'],
Expand Down

0 comments on commit ea9aa0d

Please sign in to comment.