Merge pull request ccxt#3202 from compositor/fetch

Ensure a build fails if mocha tests fail

js/test/base/test.base.js

@@ -16,10 +16,16 @@ describe ('ccxt base code', () => {
 /*  ------------------------------------------------------------------------ */
 
     require ('./functions/test.generic')
-    require ('./functions/test.number')
     require ('./functions/test.time')
     require ('./functions/test.type')
-    require ('./functions/test.datetime')
+    // Some test files are transplitted into other languages and must be kept very simple so we put `it` call externally to them
+    // Some mocha reporters will swallow `assert` failures if they are outside of `it` clause so we must call `it`
+    it ('decimalToPrecision() works', () => {
+        require ('./functions/test.number')
+    })
+    it ('date&time functions work', () => {
+        require('./functions/test.datetime')
+    })
 
 /*  ------------------------------------------------------------------------ */
 

package.json

@@ -17,7 +17,7 @@
     "test": "npm run build && node run-tests",
     "fast-test": "node run-tests --js",
     "test-base": "npm run test-js-base && npm run test-python-base && npm run test-php-base",
-    "test-js-base": "mocha --reporter spec js/test/base/test.base.js --reporter ololog/reporter",
+    "test-js-base": "mocha js/test/base/test.base.js --reporter ololog/reporter",
     "test-python-base": "python python/test/test_decimal_to_precision.py",
     "test-php-base": "php -f php/test/decimal_to_precision.php",
     "export-exchanges": "node export-exchanges",