Skip to content

Commit

Permalink
luno, gdax, coinspot, paymium, coinsecure createOrder market argument…
Browse files Browse the repository at this point in the history
… → symbol fix ccxt#2515
  • Loading branch information
kroitor committed Apr 9, 2018
1 parent 35c51a7 commit 8ba2e23
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion ccxt.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ declare module 'ccxt' {
marketIds (symbols: string[]): string[];
symbol (symbol: string): string;
extractParams (str: string): string[];
createOrder (market: string, type: string, side: string, amount: string, price?: string, params?: string): Promise<any>;
createOrder (symbol: string, type: string, side: string, amount: string, price?: string, params?: string): Promise<any>;
fetchBalance (params?: any): Promise<Balances>;
fetchTotalBalance (params?: any): Promise<PartialBalances>;
fetchUsedBalance (params?: any): Promise<PartialBalances>;
Expand Down
2 changes: 1 addition & 1 deletion js/coinsecure.js
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ module.exports = class coinsecure extends Exchange {
}
}

async createOrder (market, type, side, amount, price = undefined, params = {}) {
async createOrder (symbol, type, side, amount, price = undefined, params = {}) {
await this.loadMarkets ();
let method = 'privatePutUserExchange';
let order = {};
Expand Down
4 changes: 2 additions & 2 deletions js/coinspot.js
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,12 @@ module.exports = class coinspot extends Exchange {
}, params));
}

createOrder (market, type, side, amount, price = undefined, params = {}) {
createOrder (symbol, type, side, amount, price = undefined, params = {}) {
let method = 'privatePostMy' + this.capitalize (side);
if (type === 'market')
throw new ExchangeError (this.id + ' allows limit orders only');
let order = {
'cointype': this.marketId (market),
'cointype': this.marketId (symbol),
'amount': amount,
'rate': price,
};
Expand Down
4 changes: 2 additions & 2 deletions js/gdax.js
Original file line number Diff line number Diff line change
Expand Up @@ -464,11 +464,11 @@ module.exports = class gdax extends Exchange {
return this.parseOrders (response, market, since, limit);
}

async createOrder (market, type, side, amount, price = undefined, params = {}) {
async createOrder (symbol, type, side, amount, price = undefined, params = {}) {
await this.loadMarkets ();
// let oid = this.nonce ().toString ();
let order = {
'product_id': this.marketId (market),
'product_id': this.marketId (symbol),
'side': side,
'size': amount,
'type': type,
Expand Down
4 changes: 2 additions & 2 deletions js/luno.js
Original file line number Diff line number Diff line change
Expand Up @@ -256,10 +256,10 @@ module.exports = class luno extends Exchange {
return this.parseTrades (response['trades'], market, since, limit);
}

async createOrder (market, type, side, amount, price = undefined, params = {}) {
async createOrder (symbol, type, side, amount, price = undefined, params = {}) {
await this.loadMarkets ();
let method = 'privatePost';
let order = { 'pair': this.marketId (market) };
let order = { 'pair': this.marketId (symbol) };
if (type === 'market') {
method += 'Marketorder';
order['type'] = side.toUpperCase ();
Expand Down
4 changes: 2 additions & 2 deletions js/paymium.js
Original file line number Diff line number Diff line change
Expand Up @@ -158,10 +158,10 @@ module.exports = class paymium extends Exchange {
return this.parseTrades (response, market, since, limit);
}

async createOrder (market, type, side, amount, price = undefined, params = {}) {
async createOrder (symbol, type, side, amount, price = undefined, params = {}) {
let order = {
'type': this.capitalize (type) + 'Order',
'currency': this.marketId (market),
'currency': this.marketId (symbol),
'direction': side,
'amount': amount,
};
Expand Down

0 comments on commit 8ba2e23

Please sign in to comment.