Skip to content

Commit

Permalink
RDK-38254 : Fixed uploadReport method name.
Browse files Browse the repository at this point in the history
  • Loading branch information
sborushevsky committed Dec 16, 2022
1 parent e5654a9 commit dd068b8
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion Telemetry/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ All notable changes to this RDK Service will be documented in this file.

## [1.1.0] - 2022-10-21
### Added
- Added uploadLogs call (triggers processing and uploading of telemetry report for legacy Xconf based configuration)
- Added uploadReport call (triggers processing and uploading of telemetry report for legacy Xconf based configuration)

## [1.0.0] - 2022-05-11
### Added
Expand Down
2 changes: 1 addition & 1 deletion Telemetry/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ curl --header "Content-Type: application/json" --request POST --data '{"jsonrpc"

curl --header "Content-Type: application/json" --request POST --data '{"jsonrpc":"2.0","id":"3","method": "org.rdk.Telemetry.1.logApplicationEvent", "params" : {"eventName" : "event", "eventValue" : "value" }}' http://127.0.0.1:9998/jsonrpc

curl --header "Content-Type: application/json" --request POST --data '{"jsonrpc":"2.0","id":"3","method": "org.rdk.Telemetry.1.uploadLogs"}' http://127.0.0.1:9998/jsonrpc
curl --header "Content-Type: application/json" --request POST --data '{"jsonrpc":"2.0","id":"3","method": "org.rdk.Telemetry.1.uploadReport"}' http://127.0.0.1:9998/jsonrpc
6 changes: 3 additions & 3 deletions Telemetry/Telemetry.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
// Methods
#define TELEMETRY_METHOD_SET_REPORT_PROFILE_STATUS "setReportProfileStatus"
#define TELEMETRY_METHOD_LOG_APPLICATION_EVENT "logApplicationEvent"
#define TELEMETRY_METHOD_UPLOAD_LOGS "uploadLogs"
#define TELEMETRY_METHOD_UPLOAD_REPORT "uploadReport"

#define TELEMETRY_METHOD_EVT_ON_REPORT_UPLOAD "onReportUpload"

Expand Down Expand Up @@ -84,7 +84,7 @@ namespace WPEFramework

Register(TELEMETRY_METHOD_SET_REPORT_PROFILE_STATUS, &Telemetry::setReportProfileStatus, this);
Register(TELEMETRY_METHOD_LOG_APPLICATION_EVENT, &Telemetry::logApplicationEvent, this);
Register(TELEMETRY_METHOD_UPLOAD_LOGS, &Telemetry::uploadLogs, this);
Register(TELEMETRY_METHOD_UPLOAD_REPORT, &Telemetry::uploadReport, this);

Utils::Telemetry::init();
}
Expand Down Expand Up @@ -274,7 +274,7 @@ namespace WPEFramework
}

#endif
uint32_t Telemetry::uploadLogs(const JsonObject& parameters, JsonObject& response)
uint32_t Telemetry::uploadReport(const JsonObject& parameters, JsonObject& response)
{
LOGINFOMETHOD();
#ifdef HAS_RBUS
Expand Down
2 changes: 1 addition & 1 deletion Telemetry/Telemetry.h
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ namespace WPEFramework {
//Begin methods
uint32_t setReportProfileStatus(const JsonObject& parameters, JsonObject& response);
uint32_t logApplicationEvent(const JsonObject& parameters, JsonObject& response);
uint32_t uploadLogs(const JsonObject& parameters, JsonObject& response);
uint32_t uploadReport(const JsonObject& parameters, JsonObject& response);
//End methods

public:
Expand Down
2 changes: 1 addition & 1 deletion Tests/tests/test_Telemetry.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ TEST_F(TelemetryTest, RegisteredMethods)
{
EXPECT_EQ(Core::ERROR_NONE, handler.Exists(_T("setReportProfileStatus")));
EXPECT_EQ(Core::ERROR_NONE, handler.Exists(_T("logApplicationEvent")));
EXPECT_EQ(Core::ERROR_NONE, handler.Exists(_T("uploadLogs")));
EXPECT_EQ(Core::ERROR_NONE, handler.Exists(_T("uploadReport")));
}

TEST_F(TelemetryRfcTest, InitializeDefaultProfile)
Expand Down

0 comments on commit dd068b8

Please sign in to comment.