Use correct first bucket during grow
#28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! I just confirmed it fixes iced-rs/iced#2132. Thank you!
It's fine with me! We don't rely on the grow behavior directly; as long as But since we are changing semantics, this should probably be released as a new minor version. There may be other libraries relying on the current |
hecrj
approved these changes
Nov 11, 2023
|
Awesome! Confirmed this also fixes an Iced issue I was wrestling with rendering text in languages with many characters (which is present on 0.2.8) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression caused by using the wrong next bucket in #27 Confirmed to work with iced's
tourexample.I think this is correct but it would be helpful if anyone could double check the
first_bucketlogic here.Also updated the
grow_horizontallyexample to avoid the allocation failing after resize because of shelf height. I'd like to double check that this expectation change is ok with @hecrj before merging.