Issue with snapping to View Item if a tap was detected in the iCarousel but not on a iCarousel View Item #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2078,6 +2078,9 @@ - (void)didTap:(UITapGestureRecognizer *)tapGesture | |||
| [self scrollToItemAtIndex:self.currentItemIndex animated:YES]; | |||
| } | |||
| } | |||
| else { | |||
|
@nicklockwood updated |
nicklockwood
added a commit
that referenced
this pull request
Jul 8, 2015
…item Issue with snapping to View Item if a tap was detected in the iCarousel but not on a iCarousel View Item
|
Looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opened from #633 moving the commit to it's own branch to hopefully get this accepted.
Fixes an issue where if you tap outside of a carousel view item, but within the carousel (like at the end of the carousel) the scrolling will freeze in place and not snap to either the previous selected item or the one that was being scrolled to.
A little hard to explain, let me know if more information is needed here