Fix hang with large files by removing re.search title for non-html re…

…sponses
nikhilbadyal · Mar 25, 2023 · c5fc8db · c5fc8db
1 parent d6b7aca
commit c5fc8db
Showing 1 changed file with 29 additions and 18 deletions.
diff --git a/gdown/download.py b/gdown/download.py
@@ -174,26 +174,37 @@ def download(
                 id=gdrive_file_id
             )
             continue
-        m = re.search("<title>(.+)</title>", res.text)
-        if m and m.groups()[0].endswith(" - Google Docs"):
-            url = (
-                "https://docs.google.com/document/d/{id}/export"
-                "?format={format}".format(
-                    id=gdrive_file_id,
-                    format="docx" if format is None else format,
+
+        if res.headers["Content-Type"].startswith("text/html"):
+            m = re.search("<title>(.+)</title>", res.text)
+            if m and m.groups()[0].endswith(" - Google Docs"):
+                url = (
+                    "https://docs.google.com/document/d/{id}/export"
+                    "?format={format}".format(
+                        id=gdrive_file_id,
+                        format="docx" if format is None else format,
+                    )
                 )
-            )
-            continue
-        elif m and m.groups()[0].endswith(" - Google Sheets"):
-            url = (
-                "https://docs.google.com/spreadsheets/d/{id}/export"
-                "?format={format}".format(
-                    id=gdrive_file_id,
-                    format="xlsx" if format is None else format,
+                continue
+            elif m and m.groups()[0].endswith(" - Google Sheets"):
+                url = (
+                    "https://docs.google.com/spreadsheets/d/{id}/export"
+                    "?format={format}".format(
+                        id=gdrive_file_id,
+                        format="xlsx" if format is None else format,
+                    )
                 )
-            )
-            continue
-        elif (m and m.groups()[0].endswith(" - Google Slides")) or (
+                continue
+            elif m and m.groups()[0].endswith(" - Google Slides"):
+                url = (
+                    "https://docs.google.com/presentation/d/{id}/export"
+                    "?format={format}".format(
+                        id=gdrive_file_id,
+                        format="pptx" if format is None else format,
+                    )
+                )
+                continue
+        elif (
             "Content-Disposition" in res.headers
             and res.headers["Content-Disposition"].endswith("pptx")
             and format not in {None, "pptx"}