fix: travis builds checks (via Python instead) (frappe#10659)

.travis.yml

@@ -47,27 +47,11 @@ matrix:
     script: bench --site test_site run-ui-tests frappe --headless
 
 before_install:
- # do we really want to run travis? check which files are changed and if git doesnt face any fatal errors
+ # do we really want to run travis?
   - |
-    FILES_CHANGED=$( git diff --name-only $TRAVIS_COMMIT_RANGE 2>&1 )
-
-    if [[ $FILES_CHANGED != *"fatal"* ]]; then
-      ONLY_DOCS_CHANGES=$( echo $FILES_CHANGED | grep -qvE '\.(md|png|jpg|jpeg)$|^.github|LICENSE' ; echo $? )
-      ONLY_JS_CHANGES=$( echo $FILES_CHANGED | grep -qvE '\.js$' ; echo $? )
-      ONLY_PY_CHANGES=$( echo $FILES_CHANGED | grep -qvE '\.py$' ; echo $? )
-
-      if [[ $ONLY_DOCS_CHANGES == "1" ]]; then
-          echo "Only docs were updated, stopping build process.";
-          exit;
-      fi
-      if [[ $ONLY_JS_CHANGES == "1"  && $TYPE == "server" ]]; then
-          echo "Only JavaScript code was updated; Stopping Python build process.";
-          exit;
-      fi
-      if [[ $ONLY_PY_CHANGES == "1"  && $TYPE == "ui" ]]; then
-          echo "Only Python code was updated, stopping Cypress build process.";
-          exit;
-      fi
+    python ./.travis/roulette.py
+    if [[ $? != 2 ]];then
+      exit;
     fi
 
  # install wkhtmltopdf

.travis/roulette.py

@@ -0,0 +1,51 @@
+# if the script ends with exit code 0, then no tests are run further, else all tests are run
+import os
+import re
+import shlex
+import subprocess
+import sys
+
+
+def get_output(command, shell=True):
+    print(command)
+    command = shlex.split(command)
+    return subprocess.check_output(command, shell=shell, encoding="utf8").strip()
+
+def is_py(file):
+    return file.endswith("py")
+
+def is_js(file):
+    return file.endswith("js")
+
+def is_docs(file):
+    regex = re.compile('\.(md|png|jpg|jpeg)$|^.github|LICENSE')
+    return bool(regex.search(file))
+
+
+if __name__ == "__main__":
+    build_type = os.environ.get("TYPE")
+    commit_range = os.environ.get("TRAVIS_COMMIT_RANGE")
+    print("Build Type: {}".format(build_type))
+    print("Commit Range: {}".format(commit_range))
+
+    files_changed = get_output("git diff --name-only {}".format(commit_range), shell=False)
+
+    if "fatal" not in files_changed:
+        files_list = files_changed.split()
+        only_docs_changed = len(list(filter(is_docs, files_list))) == len(files_list)
+        only_js_changed = len(list(filter(is_js, files_list))) == len(files_list)
+        only_py_changed = len(list(filter(is_py, files_list))) == len(files_list)
+
+        if only_docs_changed:
+            print("Only docs were updated, stopping build process.")
+            sys.exit(0)
+
+        if only_js_changed and build_type == "server":
+            print("Only JavaScript code was updated; Stopping Python build process.")
+            sys.exit(0)
+
+        if only_py_changed and build_type == "ui":
+            print("Only Python code was updated, stopping Cypress build process.")
+            sys.exit(0)
+
+    sys.exit(2)