Skip to content

fixed about 1000 potential vulnerabilities in dependencies #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed about 1000 potential vulnerabilities in dependencies #1

wants to merge 1 commit into from

Conversation

curdbecker
Copy link

  • Updated dependencies and let npm audit fix take care about 1000 potential vulnerabilities in dependencies.

@Bettelstab Bettelstab self-requested a review August 3, 2018 16:21
Bettelstab
Bettelstab suggested changes Aug 3, 2018
View reviewed changes
Copy link

@Bettelstab Bettelstab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just dev dependencies and we never build it, but use the source code directly / bundle it with our own tools. All dev dependencies should be removed instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bettelstab Bettelstab Bettelstab requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curdbecker @Bettelstab