Gas optimization on average function of Math.sol (OpenZeppelin#2757)

* change implementation to save gas * add average test with two max uni256 number
niukouMan · Jul 10, 2021 · 6d97f09 · 6d97f09
1 parent 1c1ebd7
commit 6d97f09
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/contracts/utils/math/Math.sol b/contracts/utils/math/Math.sol
@@ -25,8 +25,8 @@ library Math {
      * zero.
      */
     function average(uint256 a, uint256 b) internal pure returns (uint256) {
-        // (a + b) / 2 can overflow, so we distribute.
-        return (a / 2) + (b / 2) + (((a % 2) + (b % 2)) / 2);
+        // (a + b) / 2 can overflow.
+        return (a & b) + (a ^ b) / 2;
     }
 
     /**

diff --git a/test/utils/math/Math.test.js b/test/utils/math/Math.test.js
@@ -54,6 +54,11 @@ contract('Math', function (accounts) {
       const b = new BN('84346');
       expect(await this.math.average(a, b)).to.be.bignumber.equal(bnAverage(a, b));
     });
+
+    it('is correctly calculated with two max uint256 numbers', async function () {
+      const a = MAX_UINT256;
+      expect(await this.math.average(a, a)).to.be.bignumber.equal(bnAverage(a, a));
+    });
   });
 
   describe('ceilDiv', function () {