filestore: check ioctl WAIT_SYNC return value

CID 716860: Unchecked return value (CHECKED_RETURN) At (27): Calling function "ioctl(int, unsigned long, ...)" without checking return value (as is done elsewhere 29 out of 31 times). Signed-off-by: Sage Weil <[email protected]>
niumowm · Oct 1, 2012 · 409fbb7 · 409fbb7
1 parent 15ebc0f
commit 409fbb7
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/os/FileStore.cc b/src/os/FileStore.cc
@@ -3695,7 +3695,12 @@ void FileStore::sync_entry()
 
 	  // wait for commit
 	  dout(20) << " waiting for transid " << async_args.transid << " to complete" << dendl;
-	  ::ioctl(op_fd, BTRFS_IOC_WAIT_SYNC, &async_args.transid);
+	  r = ::ioctl(op_fd, BTRFS_IOC_WAIT_SYNC, &async_args.transid);
+	  if (r < 0) {
+	    int err = errno;
+	    derr << "ioctl WAIT_SYNC got " << cpp_strerror(err) << dendl;
+	    assert(0 == "wait_sync got error");
+	  }
 	  dout(20) << " done waiting for transid " << async_args.transid << " to complete" << dendl;
 
 	} else {