Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updater: enforce trailing slash requirement #70

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

ajs124
Copy link
Contributor

@ajs124 ajs124 commented Dec 16, 2020

I needed to build another ROM to get OTA updates to work, because I didn't read the description and omitted the trailing slash.

Alternatively an assert could be used.

@danielfullmer danielfullmer merged commit 5983a39 into nix-community:master Dec 16, 2020
@danielfullmer
Copy link
Collaborator

Just now remembered lib.hasSuffix, which makes this a bit nicer: ff67f78

@ajs124 ajs124 deleted the updater_slash branch December 16, 2020 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants