Skip to content

Commit

Permalink
Declare frontend group dependency & use explicit dependencies in laun…
Browse files Browse the repository at this point in the history
…ch_testing (ros2#520)

* Switch to package format 3

Signed-off-by: Christophe Bedard <[email protected]>

* Declare dependency on launch_{xml,yaml} in launch_testing

Signed-off-by: Christophe Bedard <[email protected]>

* Declare a 'launch_frontend_packages' group and use in launch_testing

Signed-off-by: Christophe Bedard <[email protected]>
  • Loading branch information
christophebedard authored Nov 23, 2021
1 parent 81085cf commit a7657a5
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 6 deletions.
9 changes: 7 additions & 2 deletions launch_testing/package.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0"?>
<?xml-model href="http://download.ros.org/schema/package_format2.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="2">
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>launch_testing</name>
<version>0.19.0</version>
<description>A package to create tests which involve launch files and multiple processes.</description>
Expand All @@ -17,6 +17,9 @@

<exec_depend>ament_index_python</exec_depend>
<exec_depend>launch</exec_depend>
<!-- explicitly depend on the main launch frontends -->
<exec_depend>launch_xml</exec_depend>
<exec_depend>launch_yaml</exec_depend>
<exec_depend>osrf_pycommon</exec_depend>
<exec_depend>python3-pytest</exec_depend>

Expand All @@ -25,6 +28,8 @@
<test_depend>ament_pep257</test_depend>
<test_depend>launch</test_depend>

<group_depend>launch_frontend_packages</group_depend>

<export>
<build_type>ament_python</build_type>
</export>
Expand Down
6 changes: 4 additions & 2 deletions launch_xml/package.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0"?>
<?xml-model href="http://download.ros.org/schema/package_format2.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="2">
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>launch_xml</name>
<version>0.19.0</version>
<description>XML frontend for the launch package.</description>
Expand All @@ -20,6 +20,8 @@
<test_depend>ament_pep257</test_depend>
<test_depend>python3-pytest</test_depend>

<member_of_group>launch_frontend_packages</member_of_group>

<export>
<build_type>ament_python</build_type>
</export>
Expand Down
6 changes: 4 additions & 2 deletions launch_yaml/package.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0"?>
<?xml-model href="http://download.ros.org/schema/package_format2.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="2">
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>launch_yaml</name>
<version>0.19.0</version>
<description>YAML frontend for the launch package.</description>
Expand All @@ -20,6 +20,8 @@
<test_depend>ament_pep257</test_depend>
<test_depend>python3-pytest</test_depend>

<member_of_group>launch_frontend_packages</member_of_group>

<export>
<build_type>ament_python</build_type>
</export>
Expand Down

0 comments on commit a7657a5

Please sign in to comment.