Skip to content

Commit

Permalink
Allow CI to pass when uploading to artifacts fails (pytorch#1768)
Browse files Browse the repository at this point in the history
Summary:
## Motivation

This has been failing flakily, which is annoying. This is not an ideal fix but will stop the CI from failing when uploading performance data to the artifacts branch fails.

### Have you read the [Contributing Guidelines on pull requests](https://github.com/pytorch/botorch/blob/main/CONTRIBUTING.md#pull-requests)?

Yes

Pull Request resolved: pytorch#1768

Test Plan: See if it breaks again after this is landed

Reviewed By: Balandat

Differential Revision: D44477955

Pulled By: esantorella

fbshipit-source-id: 91b009133875ac98071e7dc1728d9092265bee38
  • Loading branch information
esantorella authored and facebook-github-bot committed Mar 28, 2023
1 parent 96a9c9c commit c0e94dd
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/reusable_tutorials.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ jobs:
python scripts/run_tutorials.py -p "$(pwd)"
- if: ${{ inputs.upload_artifact }}
name: Upload performance data to artifacts branch
# Sometimes pushing to this branch doesn't work -- fix planned
continue-on-error: true
# 1) Switch to artifacts branch
# 2) Add the new CSV file
# 3) Get .py and .ipynb files needed for analyzing tutorials data from main
Expand Down

0 comments on commit c0e94dd

Please sign in to comment.