-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NIX_STATE_HOME, NIX_DATA_HOME, NIX_CONFIG_HOME and NIX_CACHE_HOME #1
Open
noamraph
wants to merge
55
commits into
master
Choose a base branch
from
add-nix-state-home
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noamraph
force-pushed
the
add-nix-state-home
branch
from
August 12, 2024 12:14
5ce1f6d
to
dfb24f9
Compare
noamraph
force-pushed
the
add-nix-state-home
branch
from
August 18, 2024 17:58
dfb24f9
to
2a77d37
Compare
Starting in macOS 15 Sequoia, macOS daemon UIDs are encroaching on our default UIDs of 301-332. This commit relocates our range up to avoid clashing with the current UIDs of 301-304 and buy us a little time while still leaving headroom for people installing more than 32 users.
This constructor is used for public keys as well.
Don't refer to public keys as secret keys in error
This broke in NixOS#11005. Any number of PathSubstitutionGoals would be woken up by a single build slot becoming available. If there are a lot of substitution goals active, this could lead to us running out of file descriptors (especially on macOS where the default limit is 256).
Slight cleanup.
Fix link anchor
…tution-jobs Respect max-substitution-jobs again
…-cleanup maintainers/upload-release.pl: Delete temporary directories when we're done
The daemon process is now moved into a new sub-cgroup called nix-daemon when the daemon starts. This is necessary to abide by the no-processes-in-inner-nodes rule, because the service cgroup becomes an inner node when the child cgroups for the build are created (see LocalDerivationGoal::startBuilder()). See NixOS#9675
Prior to this commit, the unit contained this line: ExecStart=@share/nix-daemon nix-daemon --daemon which caused systemd to complain: Failed to restart nix-daemon.service: Unit nix-daemon.service has a bad unit file setting. See system logs and 'systemctl status nix-daemon.service' for details. and had this in the unit output: Sep 03 13:34:59 scadrial systemd[1]: /etc/systemd/system/nix-daemon.service:10: Neither a valid executable name nor an absolute path: share/nix-daemon Sep 03 13:34:59 scadrial systemd[1]: nix-daemon.service: Unit configuration has fatal error, unit will not be started. (Notice how it's trying to execute `share/nix-daemon`, which is unlikely to exist.) Now with this commit, the path to the daemon binary is properly set: ExecStart=@/nix/store/lcbx6d8gzznf3z3c8lsv9jy3j6c67x6r-nix-2.25.0pre20240903_dirty/bin/nix-daemon nix-daemon --daemon
install-darwin: fix _nixbld uids for macOS sequoia
Enable cgroups delegation for systemd
Co-authored-by: Eelco Dolstra <[email protected]>
Static local initializers are atomic in C++.
Pull fut.get() out of the lock
I hardcoded the wrong GID (30001 instead of 30000), but it's better to just pick up the GID from the existing group.
- highlighted example - linked definitions to the glossary (this is a shorter read) - fixed some artefact
this makes it less cumbersome to read and puts the statements in meaningful order.
this should make it more obvious how things are related to each other, and also hopefully expose the historical context without having to say on every corner that these details are accounting for legacy decisions.
use existing GID in sequoia migration script
This reverts commit 9b1cefe.
This reverts commit c9f4567. This now triggers on simple cases like `nix build .#nix`. Reverting for now.
Revert "fix: Error on malformed URI query parameter"
…nstructions update instructions to build the manual
fixup: use the real bindir for systemd unit's bindir
…-docs docs: explain provenance of default `nix-path` values
…gloss docs: reword glossary entry on Nix expression
docs: small fixups on the default expression
Move daemon process into sub-cgroup
progress-bar: Only write when truly updated
Co-authored-by: Valentin Gagarin <[email protected]>
Co-authored-by: Valentin Gagarin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.