Refactor to use columnRanges and improve column cursor movement #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored code to utilize `columnRanges` for better cursor movement. - Updated column cursor movement logic to first determine if only scrolling is needed without moving the cursor. - Removed `columnStart` from `Document` struct. - Added `determineColumnStart` function to determine the start index of columns. - Updated `moveBeginLeft` and `moveEndRight` functions to use screen information. - Improved `optimalCursor` and `optimalX` functions for better cursor positioning. - Added `isValidCursor`, `rightEdge`, and `targetLineWithColumns` helper functions. - Updated `prepareDraw` and `prepareLines` functions to handle column ranges. - Modified related tests to reflect the changes in column handling. - Added support for header column using `columnRanges`. - Unified variable name `LineC` to `lineC`. - Added support for wide characters to ensure proper display and handling. - Modified relevant files to reflect these changes.
Updated the logic to check if a column fits within the screen to consider the vertical header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor to use columnRanges and improve column cursor movement