Skip to content

Missing docs #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2015
Merged

Missing docs #31

merged 2 commits into from
Jul 21, 2015

Conversation

aheuermann
Copy link
Contributor

I noticed Commit#getDiff was missing from the docs. dox wasn't parsing all the methods. Upgrading to 0.8.0 seemed to fix it. Fixes #20 as well.

@tbranyen
Copy link
Member

Just so I'm clear, you upgraded dox and then generated the latest files? There's a lot of changes here and I'm hesitant to merge in any manual fixes.

@tbranyen
Copy link
Member

Nevermind it's clear from the commits and their messages. Merging!

tbranyen added a commit that referenced this pull request Jul 21, 2015
@tbranyen tbranyen merged commit e16b671 into nodegit:master Jul 21, 2015
@tbranyen
Copy link
Member

Thanks! :)

@tbranyen
Copy link
Member

Receiving this error locally, strange:

/home/tim/git/nodegit/nodegit.github.com/node_modules/dox/node_modules/jsdoctypeparser/lib/index.js:53
          throw new Lexer.SyntaxError(e.message, typeExp, e.offset);
                ^
TypeLexerSyntaxError: Expected "!", "(", "*", "...", "=", "?", "function", "module", "{" or [a-zA-Z_$] but "[" found.:
[String]
^

@tbranyen
Copy link
Member

Seems to be a bug with the 0.4.1 tag, fixed in our master, disregard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some convenience methods aren't being included
2 participants